1262378 - Use automation to flag literal uses of "Firefox" in localized strings

Status: NEW

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

Because we should normally use brandShortName to render it instead.

Comment 1

[Axel Hecht [:Pike]]

I suspect that most cases are OK these days, but I guess we'll have a few still.

Notably, toolkit overrides where the toolkit version doesn't provide a brand.

https://transvision.mozfr.org/?recherche=Firefox&repo=central&sourcelocale=en-US&locale=de&search_type=strings_entities is a good search.

Comment 2

[Francesco Lodolo [:flod]]

This might be less scary (no German)
https://transvision.mozfr.org/?recherche=Firefox&repo=central&sourcelocale=en-US&locale=en-US&search_type=strings

Also, something to parse with scripts
https://transvision.mozfr.org/api/v1/search/strings/central/en-US/en-US/Firefox/

Comment 3

[:Gijs (he/him)]

I'm really confused by all these links. We can just use the existing test that landed in bug 1259859, which is much simpler.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to :Gijs Kruitbosch from comment #3)
> I'm really confused by all these links. We can just use the existing test
> that landed in bug 1259859, which is much simpler.

The links are to see which strings use "Firefox" literally, and figure out which make sense to keep as they are.