1262519 - "Change Search Settings" in location-bar dropdown has a hover-background that it too subtle & inconsistent with other menus

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Open Firefox Nightly.
 2. Type a single character into location bar.
 3. Hover the "Change Search Settings" at bottom-right.
(OPTIONAL): Repeat with search bar.

ACTUAL RESULTS:
In location-bar dropdown, the "Change Search Settings" background-color has an extremely subtle change (dark gray to darker gray) when it's hovered. I barely even notice it, if I'm not staring directly at it.

In contrast, the same button in the search-bar dropdown has a much more striking background-color change -- dark gray to orange.

EXPECTED RESULTS:
Consistent background-color changes for these equivalent buttons. (I prefer the way things work in the search bar, because it's more visible.)

Comment 1

[Daniel Holbert [:dholbert]]

I'm using Ubuntu 16.04, with gnome-shell (probably not required to trigger this bug), and the "Ambiance" GTK theme (which I believe is the default).

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast of inconsistency

Here's a screencast showing the hover state of this button in the location bar (extremely-subtle darker background on hover) vs. the search bar (orange background on hover).

Comment 3

[Daniel Holbert [:dholbert]]

ni=florian who I think worked on this UI. Florian, do you know if there's a reason these buttons aren't consistent, and could we make them consistent?

Comment 4

[Marco Bonardo [:mak]]

the reason is that the bottom bar of the locationbar is nightly-only and didn't get attention yet.

We need to implement one-off buttons and change that text to a gear icon (probably)

Comment 5

[Marco Bonardo [:mak]]

fwiw, it's also now too tall compared to the entries.

Comment 6

[Daniel Holbert [:dholbert]]

[For reference, the search bar (my reference for "good behavior" here) has only been "good" since bug 1187393.  Before that, it had a awkward light-gray background which changed to a darker-gray on hover.]

Comment 7

[Marco Bonardo [:mak]]

thanks for pointing that out. Yes, when we implement one-off buttons and fix that button, we should try to be consistent with the search bar.

Comment 8

[Drew Willcoxon :adw]

I'm going to mark this as wontfix since bug 1180944, the one-off search buttons, will be landing soon, probably at the start of the next cycle.  I could wait until that bug actually lands to close this, but I just happened to come across this now, and I don't think there's value in tracking it via a dependency or keeping it open.

I'm also going to remove the dependency on bug 1262507 since that bug concerns the restyling of the popup's results, not the search settings button.

Daniel, once bug 1180944 lands, please don't hesitate to file bugs you find and CC Florian and me on them.