Closed Bug 1262525 Opened 6 years ago Closed 6 years ago

New awesomebar design: Properly emphasize/highlight search string text on Windows classic theme

Categories

(Firefox :: Address Bar, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID
Tracking Status
firefox48 --- affected

People

(Reporter: adw, Unassigned)

References

Details

The new awesomebar popup design uses `@media not all and (-moz-windows-default-theme)` to detect non-default system themes and uses system text colors for such themes.  Emphasized/highlighted text is not colored differently from non-emphasized text due to the small number of system colors, which does not match the design spec.

The class Windows theme is a non-default theme, so unfortunately it gets the non-emphasized text even though the hardcoded text colors would look fine on it.

We should be able to use `-moz-system-metric(windows-classic)` to detect the classic theme specifically.

http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css?rev=061165ac1ff9#1490
Summary: New awesomebar design: Properly emphasis/highlight search string text on Windows classic theme → New awesomebar design: Properly emphasize/highlight search string text on Windows classic theme
could font-weight: 300 (or 200) help us here?
See Also: → 1262526
I didn't intend for this bug to be about design choices or making things more legible, just simply that we should use -moz-system-metric(windows-classic) to detect the classic system theme and apply the normal/hardcoded styles and colors to it.  In the CSS, it shouldn't be considered a "non-default" theme.
There's -moz-windows-classic too, which might be better actually.

https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries#-moz-windows-classic
Classic themes can have completely arbitrary colors. You can't use that as a gatekeeper for hard-coding colors.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.