1262525 - New awesomebar design: Properly emphasize/highlight search string text on Windows classic theme

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Drew Willcoxon :adw]

The new awesomebar popup design uses `@media not all and (-moz-windows-default-theme)` to detect non-default system themes and uses system text colors for such themes.  Emphasized/highlighted text is not colored differently from non-emphasized text due to the small number of system colors, which does not match the design spec.

The class Windows theme is a non-default theme, so unfortunately it gets the non-emphasized text even though the hardcoded text colors would look fine on it.

We should be able to use `-moz-system-metric(windows-classic)` to detect the classic theme specifically.

http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css?rev=061165ac1ff9#1490

Comment 1

[Marco Bonardo [:mak]]

could font-weight: 300 (or 200) help us here?

Comment 2

[Drew Willcoxon :adw]

I didn't intend for this bug to be about design choices or making things more legible, just simply that we should use -moz-system-metric(windows-classic) to detect the classic system theme and apply the normal/hardcoded styles and colors to it.  In the CSS, it shouldn't be considered a "non-default" theme.

Comment 3

[Drew Willcoxon :adw]

There's -moz-windows-classic too, which might be better actually.

https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries#-moz-windows-classic

Comment 4

[Dão Gottwald [:dao]]

Classic themes can have completely arbitrary colors. You can't use that as a gatekeeper for hard-coding colors.