1262536 - Pass dump success status to GeckoCrashReporter

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

It looks like nsExceptionHandler::MinidumpCallback() gets an argument indicating whether or not the dump was successful or not. We should pass this state on to GeckoCrashReporter in the intent so we can know the dump failed or if we are just failing to submit the dump there.

[0] https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/nsExceptionHandler.cpp?case=true&from=nsExceptionHandler.cpp#783

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like the 'success' argument is derived from the exit code of the dump process[0], which I think should be a pretty good indicator.

[0] https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/linux/handler/exception_handler.cc#567

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

It might also be useful to log the exit code so it shows up in any submitted logcats.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: Proposed patch

This passes the success/failure status to CrashReporter as an extra boolean, and CrashReporter adds it to the report and outputs a logcat message if the minidump is unsuccessful.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/431c362daaa5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/431c362daaa5