1262617 - Viewing a recipe revision creates a new revision

Status: RESOLVED FIXED

(Shield :: General, defect)

Description

[Osmose [:osmose, :mkelly]]

In the admin interface, when I view an older revision of a recipe, and then return to the revision list (without reverting to the older revision), a new revision gets inserted into the list, despite no changes being made to the recipe.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/e70fdbea72d26cbf0999341118e6ebc408e8be63
[fix bug 1262617] Replace RevisionMiddleware with decorators.

RevisionMiddleware automatically creates revisions when things
change. However, viewing the revert page in the admin interface
triggers a revert (in order to generate the preview data before
actually reverting) within a transaction, and then rolls back the
transaction. But, as far as I can tell, django-reversion doesn't
handle transaction rollback and saves the revision from the revert
anyway.

Removing the middleware fixes this, but we still have to manually
trigger revision creation outside the admin. This commit adds
decorators for this to the Action ViewSet.

https://github.com/mozilla/normandy/commit/5c61747bd8806c5d30a4f82f3ea58b56bd995c8b
Merge pull request #109 from Osmose/fix-classifier-preview

[fix bug 1262617] Replace RevisionMiddleware with decorators.