1262620 - Geolocation on normandy.dev.mozaws.net doesn't work

Status: RESOLVED FIXED

(Shield :: General, defect)

Description

[Osmose [:osmose, :mkelly]]

If you visit https://normandy.dev.mozaws.net/en-US/repair/?testing with the network inspector open, you'll see a request to the /api/v1/fetch_bundle endpoint. It responds with a list of recipes and the country your IP address has been geolocated to, but geolocation is failing, so the country value is `null`. Also, any recipes that are geolocated to a specific country are failing to match due to this problem.

Perhaps the server doesn't have the geolocation database set up properly? Or is it not correctly reading the user's IP address?

Comment 1

[Michael Cooper [:mythmon]]

I looked at the servers a bit, and as far as I can tell they should have access to the geolocation database. When I looked closer at this code, it seems that we have no test coverage for geolocation and so it might not even work at all.

Comment 2

[Osmose [:osmose, :mkelly]]

Looking into this, I think we're not fetching the user's IP address properly. I've got a fix in the works.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/dc2e1e8d5c848599b1f0e01d4d86a043f1c26cc2
[bug 1262620] Fetch IP address from client correctly.

https://github.com/mozilla/normandy/commit/1668a8adef924ae36b1d0713cbb63893c8fa6d84
Merge pull request #106 from Osmose/get-ip-properly

[bug 1262620] Fetch IP address from client correctly.

Comment 4

[Michael Cooper [:mythmon]]

This is working now.

$ http POST https://normandy.dev.mozaws.net/api/v1/fetch_bundle/ locale=en-US user_id=mythmon release_channel=nightly version=48.0a1 | jq .country
"US"