1262634 - gtk2 build fails with undefined reference to moz_gtk_get_entry_min_height

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Hussam Al-Tayeb]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160404125404

Steps to reproduce:

gtk2 build fails with undefined reference to moz_gtk_get_entry_min_height.
I think this causes it https://github.com/mozilla/gecko-dev/commit/a2db24fb140dc6bccf0303bbd7137f558971adaf ?

Comment 1

[Hussam Al-Tayeb]

Setting importance to "Major" since this is a build issue and since gtk2 builds may still be needed while gtk3 integration reaches a usable state.

Comment 2

[Bill Gianopoulos [:WG9s]]

Attachment: The fix

This fixes the issue for me.

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8739257 [details] [diff] [review]
The fix

Thanks, Bill :)

Comment 4

[Bill Gianopoulos [:WG9s]]

(In reply to Karl Tomlinson (ni?:karlt) from comment #3)
> Comment on attachment 8739257 [details] [diff] [review]
> The fix
> 
> Thanks, Bill :)

Thanks for the quick r+

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/766970bd6779

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/766970bd6779