Closed
Bug 1262662
Opened 8 years ago
Closed 8 years ago
Intermittent browser_newtabmessages.js | received an expect number of history items - Got 4, expected 5
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
RESOLVED
FIXED
Firefox 49
People
(Reporter: KWierso, Assigned: oyiptong)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Comment 2•8 years ago
|
||
Olivier, any ideas whats going on here? This is the 4th most frequent orange at the moment.
Flags: needinfo?(oyiptong)
Assignee | ||
Comment 3•8 years ago
|
||
I think so. jkerim is going to be working on this as his first bug with my assistance. It's probably some state not being cleaned up properly between tests.
Flags: needinfo?(oyiptong)
Updated•8 years ago
|
Assignee: nobody → jkerim
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 7•8 years ago
|
||
This test is nearly permafail and is the top failure on OrangeFactor if the various different failure modes are added up. This needs a fix ASAP or a disabling in the mean time.
Flags: needinfo?(jkerim)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 10•8 years ago
|
||
Ok. I'm taking a look at it instead of :jkerim and will make a patch ASAP
Assignee: jkerim → oyiptong
Flags: needinfo?(jkerim)
Assignee | ||
Comment 11•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=287ae66a7ac8
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 14•8 years ago
|
||
@oyiptong, check also line 55. I think there is a yield missing on that `cleanup();`.
Assignee | ||
Comment 15•8 years ago
|
||
Good catch, :marcosc, thanks!
Comment 16•8 years ago
|
||
(In reply to Olivier Yiptong [:oyiptong] from comment #15) > Good catch, :marcosc, thanks! Always happy to help :) Ping me if you need me to give anything JS a once over.
Assignee | ||
Comment 17•8 years ago
|
||
will do
Assignee | ||
Comment 18•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=63a38a1050a5
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 29•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48783/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48783/
Attachment #8745036 -
Flags: review?(mcaceres)
Assignee | ||
Comment 30•8 years ago
|
||
This isn't complete yet, but I wanted to push something for mcaceres to review
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Attachment #8745036 -
Flags: review?(mcaceres) → review+
Comment 32•8 years ago
|
||
Comment on attachment 8745036 [details] MozReview Request: Bug 1262662 - clear history on startup for newtab messages tests r?marcosc https://reviewboard.mozilla.org/r/48783/#review45699 I can't see anything now that would be causing the intermittent now. ::: browser/components/newtab/tests/browser/browser_newtabmessages.js:124 (Diff revision 1) > visitDate: timeDaysAgo(daysAgo), > transition: (isTyped) ? TRANSITION_TYPED : TRANSITION_LINK, > }; > } > > yield PlacesTestUtils.clearHistory(); ClearHistory is already called on setup(), do you really want to call it again here? ::: browser/components/newtab/tests/browser/browser_newtabmessages.js:155 (Diff revision 1) > > yield BrowserTestUtils.withNewTab(tabOptions, function*() { > yield placesResponseAck; > let placesChangeAck = new Promise(resolve => { > NewTabWebChannel.once("clearHistoryAck", (_, msg) => { > ok(true, "a change response has been received"); maybe this should move to line 153? So it would be: ```JS yield placesResponseAck; ok(true, "a change response has been received"); ```
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 39•8 years ago
|
||
https://reviewboard.mozilla.org/r/48783/#review47039
Assignee | ||
Comment 40•8 years ago
|
||
Comment on attachment 8745036 [details] MozReview Request: Bug 1262662 - clear history on startup for newtab messages tests r?marcosc Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48783/diff/1-2/
Comment 41•8 years ago
|
||
https://reviewboard.mozilla.org/r/48783/#review47153 Looks good :)
Assignee | ||
Comment 42•8 years ago
|
||
The intermittent still shows up on windows. I'm working on fixing that.
Assignee | ||
Comment 44•8 years ago
|
||
tracking the windows failures in bug 1271177
Comment 45•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9d1bc9b90bb7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment hidden (Intermittent Failures Robot) |
Comment 47•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/cc5d9a00a4d3
status-firefox48:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•