Closed Bug 1262679 Opened 8 years ago Closed 6 years ago

Intermittent e10s test_videocontrols_standalone.html | Assertion count 1 is greater than expected range 0-0 assertions from "Overwriting an existing document channel!"

Categories

(Toolkit :: Video/Audio Controls, defect, P5)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
e10s + ---
firefox-esr52 --- wontfix
firefox59 --- wontfix
firefox60 --- fixed
firefox61 --- fixed

People

(Reporter: philor, Assigned: ebalazs_)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file, 1 obsolete file)

Edited the test case
626 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review
Summary: Intermittent test_videocontrols_standalone.html | Assertion count 1 is greater than expected range 0-0 assertions from "Overwriting an existing document channel!" → Intermittent e10s test_videocontrols_standalone.html | Assertion count 1 is greater than expected range 0-0 assertions from "Overwriting an existing document channel!"
Blocks: e10s-tests
tracking-e10s: --- → +
Intermittent e10s test failure
Priority: -- → P5
There are 30 failures over the last 7 days, the fails happen on Linux, Linux x64, linux32-stylo-disabled, linux64-qr and linux64-stylo-disabled

Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=154811922&lineNumber=4827

Here is a relevant part of the log: 

task 2018-01-08T20:18:21.721Z] 20:18:21     INFO - GECKO(1853) | [DEBUG SHUTDOWN] Register: decoder=0x7fb58b4eb800, count=16
[task 2018-01-08T20:18:21.905Z] 20:18:21     INFO - GECKO(1853) | [Child 1908, Main Thread] WARNING: Subsequent listeners are not retargetable: file /builds/worker/workspace/build/src/netwerk/protocol/http/HttpChannelChild.cpp, line 3520
[task 2018-01-08T20:18:22.300Z] 20:18:22     INFO - GECKO(1853) | [DEBUG SHUTDOWN] ShutdownDecoder: decoder: 'vorbis audio decoder' (0x7fb58fdcd7c0) flush:1
[task 2018-01-08T20:18:22.300Z] 20:18:22     INFO - GECKO(1853) | [DEBUG SHUTDOWN] operator(): pool=0x7fb58a53f300 shutdown=false count=0
[task 2018-01-08T20:18:23.136Z] 20:18:23     INFO - GECKO(1853) | MEMORY STAT | vsize 1906MB | residentFast 258MB | heapAllocated 70MB
[task 2018-01-08T20:18:23.258Z] 20:18:23     INFO - TEST-OK | toolkit/content/tests/widgets/test_videocontrols_standalone.html | took 6963ms
[task 2018-01-08T20:18:23.316Z] 20:18:23     INFO - GECKO(1853) | ++DOMWINDOW == 43 (0x7fb58987f800) [pid = 1908] [serial = 71] [outer = 0x7fb5a1582010]
[task 2018-01-08T20:18:23.361Z] 20:18:23     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_videocontrols_standalone.html | assertion count 1 is more than expected 0 assertions
[task 2018-01-08T20:18:23.363Z] 20:18:23     INFO - TEST-START | toolkit/content/tests/widgets/test_videocontrols_video_direction.html

:jaws can you please take a look? Thank you!
Flags: needinfo?(jaws)
Whiteboard: [stockwell needswork]
There are 33 failures in the past 7 days.
Platforms: Linux debug, Linux x64 debug, linux32-stylo-disabled debug, linux64-qr debug, linux64-stylo-disabled debug and windows10-64 debug.
Recent log event: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=156748398&lineNumber=4713
Relevant part of the log:
[task 2018-01-17T01:08:06.888Z] 01:08:06     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Register: decoder=0x7ff6106df200, count=23
4707
[task 2018-01-17T01:08:07.094Z] 01:08:07     INFO - GECKO(2096) | [Child 2150, Main Thread] WARNING: Subsequent listeners are not retargetable: file /builds/worker/workspace/build/src/netwerk/protocol/http/HttpChannelChild.cpp, line 3534
4708
[task 2018-01-17T01:08:07.587Z] 01:08:07     INFO - GECKO(2096) | [DEBUG SHUTDOWN] ShutdownDecoder: decoder: 'vorbis audio decoder' (0x7ff6167efd60) flush:1
4709
[task 2018-01-17T01:08:07.588Z] 01:08:07     INFO - GECKO(2096) | [DEBUG SHUTDOWN] operator(): pool=0x7ff60f5af840 shutdown=false count=0
4710
[task 2018-01-17T01:08:08.299Z] 01:08:08     INFO - GECKO(2096) | MEMORY STAT | vsize 1926MB | residentFast 271MB | heapAllocated 78MB
4711
[task 2018-01-17T01:08:08.416Z] 01:08:08     INFO - TEST-OK | toolkit/content/tests/widgets/test_videocontrols_standalone.html | took 7301ms
4712
[task 2018-01-17T01:08:08.465Z] 01:08:08     INFO - GECKO(2096) | ++DOMWINDOW == 38 (0x7ff60fbcec00) [pid = 2150] [serial = 71] [outer = 0x7ff628572010]
4713
[task 2018-01-17T01:08:08.523Z] 01:08:08     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_videocontrols_standalone.html | assertion count 1 is more than expected 0 assertions
4714
[task 2018-01-17T01:08:08.525Z] 01:08:08     INFO - TEST-START | toolkit/content/tests/widgets/test_videocontrols_video_direction.html
4715
[task 2018-01-17T01:08:08.605Z] 01:08:08     INFO - GECKO(2096) | ++DOMWINDOW == 39 (0x7ff60fbd0800) [pid = 2150] [serial = 72] [outer = 0x7ff628572010]
4716
[task 2018-01-17T01:08:08.905Z] 01:08:08     INFO - GECKO(2096) | ++DOCSHELL 0x7ff610c2b800 == 6 [pid = 2150] [id = {e9556a24-c6ff-44dc-a388-09e94a76c434}]
4717
[task 2018-01-17T01:08:08.907Z] 01:08:08     INFO - GECKO(2096) | ++DOMWINDOW == 40 (0x7ff6106e8ab0) [pid = 2150] [serial = 73] [outer = (nil)]
4718
[task 2018-01-17T01:08:08.907Z] 01:08:08     INFO - GECKO(2096) | ++DOMWINDOW == 41 (0x7ff60fbd2400) [pid = 2150] [serial = 74] [outer = 0x7ff6106e8ab0]
4719
[task 2018-01-17T01:08:08.924Z] 01:08:08     INFO - GECKO(2096) | ++DOCSHELL 0x7ff610c40800 == 7 [pid = 2150] [id = {e6356c50-f2f0-4b8f-9cf5-af0eb90611d9}]
4720
[task 2018-01-17T01:08:08.925Z] 01:08:08     INFO - GECKO(2096) | ++DOMWINDOW == 42 (0x7ff6106e8ca0) [pid = 2150] [serial = 75] [outer = (nil)]
4721
[task 2018-01-17T01:08:08.928Z] 01:08:08     INFO - GECKO(2096) | ++DOMWINDOW == 43 (0x7ff60fbd2800) [pid = 2150] [serial = 76] [outer = 0x7ff6106e8ca0]
4722
[task 2018-01-17T01:08:08.987Z] 01:08:08     INFO - GECKO(2096) | --DOCSHELL 0x7ff60f661800 == 6 [pid = 2150] [id = {7a864a2f-529b-42d6-9d02-c75a4095b5f2}]
4723
[task 2018-01-17T01:08:08.989Z] 01:08:08     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff6150ea400 state machine=0x7ff615111000
4724
[task 2018-01-17T01:08:08.989Z] 01:08:08     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff61fea8600 state machine=0x7ff621f75000
4725
[task 2018-01-17T01:08:08.991Z] 01:08:08     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff6182e7c00 state machine=0x7ff6182f9000
4726
[task 2018-01-17T01:08:08.992Z] 01:08:08     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff6182e9800 state machine=0x7ff622193000
4727
[task 2018-01-17T01:08:08.994Z] 01:08:08     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff61fea8c00 state machine=0x7ff6166de000
4728
[task 2018-01-17T01:08:08.998Z] 01:08:08     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff621f3ce00 state machine=0x7ff6272eb000
4729
[task 2018-01-17T01:08:09.000Z] 01:08:09     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff62aba4600 state machine=0x7ff61fe85000
4730
[task 2018-01-17T01:08:09.002Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 42 (0x7ff617da8000) [pid = 2150] [serial = 16] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_videocontrols.html]
4731
[task 2018-01-17T01:08:09.005Z] 01:08:09     INFO - GECKO(2096) | [DEBUG SHUTDOWN] Shutdown: decoder=0x7ff626fb1000 state machine=0x7ff6180e5000
4732
[task 2018-01-17T01:08:09.006Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 41 (0x7ff6166a8c00) [pid = 2150] [serial = 57] [outer = (nil)] [url = about:blank]
4733
[task 2018-01-17T01:08:09.008Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 40 (0x7ff61568d400) [pid = 2150] [serial = 55] [outer = (nil)] [url = about:blank]
4734
[task 2018-01-17T01:08:09.010Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 39 (0x7ff615685800) [pid = 2150] [serial = 54] [outer = (nil)] [url = about:blank]
4735
[task 2018-01-17T01:08:09.012Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 38 (0x7ff61654d000) [pid = 2150] [serial = 48] [outer = (nil)] [url = about:blank]
4736
[task 2018-01-17T01:08:09.014Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 37 (0x7ff61654b000) [pid = 2150] [serial = 43] [outer = (nil)] [url = http://mochi.test:8888/tests/SimpleTest/iframe-between-tests.html]
4737
[task 2018-01-17T01:08:09.016Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 36 (0x7ff618199800) [pid = 2150] [serial = 42] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_videocontrols_error.html]
4738
[task 2018-01-17T01:08:09.020Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 35 (0x7ff617e0dc00) [pid = 2150] [serial = 20] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_videocontrols_audio_direction.html]
4739
[task 2018-01-17T01:08:09.025Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 34 (0x7ff617da7800) [pid = 2150] [serial = 14] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_mousecapture_area.html]
4740
[task 2018-01-17T01:08:09.027Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 33 (0x7ff617da7000) [pid = 2150] [serial = 12] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_bug898940.html]
4741
[task 2018-01-17T01:08:09.028Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 32 (0x7ff61654dc00) [pid = 2150] [serial = 49] [outer = (nil)] [url = about:srcdoc]
4742
[task 2018-01-17T01:08:09.030Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 31 (0x7ff61654c800) [pid = 2150] [serial = 47] [outer = (nil)] [url = about:blank]
4743
[task 2018-01-17T01:08:09.032Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 30 (0x7ff61654a400) [pid = 2150] [serial = 44] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_videocontrols_iframe_fullscreen.html]
4744
[task 2018-01-17T01:08:09.037Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 29 (0x7ff6182d3400) [pid = 2150] [serial = 41] [outer = (nil)] [url = http://mochi.test:8888/tests/SimpleTest/iframe-between-tests.html]
4745
[task 2018-01-17T01:08:09.038Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 28 (0x7ff622184800) [pid = 2150] [serial = 8] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_audiocontrols_dimensions.html]
4746
[task 2018-01-17T01:08:09.040Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 27 (0x7ff615685000) [pid = 2150] [serial = 52] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_videocontrols_jsdisabled.html]
4747
[task 2018-01-17T01:08:09.042Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 26 (0x7ff615683c00) [pid = 2150] [serial = 51] [outer = (nil)] [url = http://mochi.test:8888/tests/SimpleTest/iframe-between-tests.html]
4748
[task 2018-01-17T01:08:09.044Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 25 (0x7ff6166c2000) [pid = 2150] [serial = 50] [outer = (nil)] [url = about:srcdoc]
4749
[task 2018-01-17T01:08:09.049Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 24 (0x7ff617daf400) [pid = 2150] [serial = 18] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_videocontrols_audio.html]
4750
[task 2018-01-17T01:08:09.051Z] 01:08:09     INFO - GECKO(2096) | --DOMWINDOW == 23 (0x7ff621f9e000) [pid = 2150] [serial = 10] [outer = (nil)] [url = http://mochi.test:8888/tests/toolkit/content/tests/widgets/test_bug1319301.html]
:jaws Could you please take a look?
here is the assertion:
[task 2018-01-17T01:08:04.716Z] 01:08:04     INFO - GECKO(2096) | [Child 2150, Main Thread] ###!!! ASSERTION: Overwriting an existing document channel!: '(loadFlags & nsIChannel::LOAD_REPLACE) || !(mDocumentRequest.get())', file /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp, line 443
[task 2018-01-17T01:08:04.716Z] 01:08:04     INFO - GECKO(2096) | #01: mozilla::net::nsLoadGroup::AddRequest [netwerk/base/nsLoadGroup.cpp:511]
[task 2018-01-17T01:08:04.716Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.722Z] 01:08:04     INFO - GECKO(2096) | #02: mozilla::BaseMediaResource::ModifyLoadFlags [dom/media/BaseMediaResource.cpp:158]
[task 2018-01-17T01:08:04.722Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.722Z] 01:08:04     INFO - GECKO(2096) | #03: mozilla::ChannelMediaResource::OnStopRequest [dom/media/ChannelMediaResource.cpp:382]
[task 2018-01-17T01:08:04.722Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.722Z] 01:08:04     INFO - GECKO(2096) | #04: mozilla::dom::MediaDocumentStreamListener::OnStopRequest [dom/html/MediaDocument.cpp:72]
[task 2018-01-17T01:08:04.722Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.723Z] 01:08:04     INFO - GECKO(2096) | #05: nsDocumentOpenInfo::OnStopRequest [uriloader/base/nsURILoader.cpp:351]
[task 2018-01-17T01:08:04.723Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.728Z] 01:08:04     INFO - GECKO(2096) | #06: mozilla::net::HttpChannelChild::DoOnStopRequest [netwerk/protocol/http/HttpChannelChild.cpp:1251]
[task 2018-01-17T01:08:04.728Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.729Z] 01:08:04     INFO - GECKO(2096) | #07: mozilla::net::HttpChannelChild::OnStopRequest [netwerk/protocol/http/HttpChannelChild.cpp:1122]
[task 2018-01-17T01:08:04.729Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.730Z] 01:08:04     INFO - GECKO(2096) | #08: mozilla::net::ChannelEventQueue::FlushQueue [netwerk/ipc/ChannelEventQueue.cpp:65]
[task 2018-01-17T01:08:04.732Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.733Z] 01:08:04     INFO - GECKO(2096) | #09: mozilla::net::ChannelEventQueue::ResumeInternal()::CompleteResumeRunnable::Run()
[task 2018-01-17T01:08:04.734Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.737Z] 01:08:04     INFO - GECKO(2096) | #10: mozilla::SchedulerGroup::Runnable::Run [xpcom/threads/SchedulerGroup.cpp:395]
[task 2018-01-17T01:08:04.738Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.739Z] 01:08:04     INFO - GECKO(2096) | #11: nsThread::ProcessNextEvent [mfbt/Maybe.h:445]
[task 2018-01-17T01:08:04.741Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.742Z] 01:08:04     INFO - GECKO(2096) | #12: NS_ProcessNextEvent [xpcom/threads/nsThreadUtils.cpp:517]
[task 2018-01-17T01:08:04.742Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.743Z] 01:08:04     INFO - GECKO(2096) | #13: mozilla::ipc::MessagePump::Run [ipc/glue/MessagePump.cpp:98]
[task 2018-01-17T01:08:04.743Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.744Z] 01:08:04     INFO - GECKO(2096) | #14: MessageLoop::RunInternal [ipc/chromium/src/base/message_loop.cc:327]
[task 2018-01-17T01:08:04.745Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.746Z] 01:08:04     INFO - GECKO(2096) | #15: MessageLoop::Run [ipc/chromium/src/base/message_loop.cc:298]
[task 2018-01-17T01:08:04.747Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.748Z] 01:08:04     INFO - GECKO(2096) | #16: nsBaseAppShell::Run [widget/nsBaseAppShell.cpp:159]
[task 2018-01-17T01:08:04.749Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.750Z] 01:08:04     INFO - GECKO(2096) | #17: XRE_RunAppShell [toolkit/xre/nsEmbedFunctions.cpp:831]
[task 2018-01-17T01:08:04.751Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.754Z] 01:08:04     INFO - GECKO(2096) | #18: mozilla::ipc::MessagePumpForChildProcess::Run [ipc/glue/MessagePump.cpp:269]
[task 2018-01-17T01:08:04.755Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.755Z] 01:08:04     INFO - GECKO(2096) | #19: MessageLoop::RunInternal [ipc/chromium/src/base/message_loop.cc:327]
[task 2018-01-17T01:08:04.756Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.757Z] 01:08:04     INFO - GECKO(2096) | #20: MessageLoop::Run [ipc/chromium/src/base/message_loop.cc:298]
[task 2018-01-17T01:08:04.757Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.758Z] 01:08:04     INFO - GECKO(2096) | #21: XRE_InitChildProcess [toolkit/xre/nsEmbedFunctions.cpp:704]
[task 2018-01-17T01:08:04.758Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.759Z] 01:08:04     INFO - GECKO(2096) | #22: content_process_main [ipc/contentproc/plugin-container.cpp:65]
[task 2018-01-17T01:08:04.759Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.760Z] 01:08:04     INFO - GECKO(2096) | #23: main [browser/app/nsBrowserApp.cpp:283]
[task 2018-01-17T01:08:04.761Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.762Z] 01:08:04     INFO - GECKO(2096) | #24: libc.so.6 + 0x20830
[task 2018-01-17T01:08:04.763Z] 01:08:04     INFO - 
[task 2018-01-17T01:08:04.763Z] 01:08:04     INFO - GECKO(2096) | #25: _start
[task 2018-01-17T01:08:04.764Z] 01:08:04     INFO -
Stefan, let's disable this test on Linux since we don't have any prioritization to dig deeper here.

The purpose of the test is to make sure that the video controls binding works correctly on standalone pages, and having Windows & OSX support for this should be sufficient.
Flags: needinfo?(jaws) → needinfo?(shindli)
Attached patch Disabled test on linux (obsolete) — — Splinter Review 
Flags: needinfo?(shindli)

        Attachment #8954668 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8954668 [details] [diff] [review]
Disabled test on linux

Review of attachment 8954668 [details] [diff] [review]:
-----------------------------------------------------------------

happy to land this patch as is, or do as I suggested below.

::: toolkit/content/tests/widgets/mochitest.ini
@@ +40,4 @@
>  [test_videocontrols_jsdisabled.html]
>  skip-if = toolkit == 'android' # bug 1272646
>  [test_videocontrols_standalone.html]
> +skip-if = toolkit == 'android' || os == 'linux' # bug 1075573, bug 1262679

you could do this for linux debug only since the failures are almost 100% on debug:
skip-if = toolkit == 'android' || (os == 'linux' && debug)

        Attachment #8954668 -
        Flags: review?(jmaher) → review+

    
    

    
  
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #45)
> ::: toolkit/content/tests/widgets/mochitest.ini
> @@ +40,4 @@
> >  [test_videocontrols_jsdisabled.html]
> >  skip-if = toolkit == 'android' # bug 1272646
> >  [test_videocontrols_standalone.html]
> > +skip-if = toolkit == 'android' || os == 'linux' # bug 1075573, bug 1262679
> 
> you could do this for linux debug only since the failures are almost 100% on
> debug:

That's not surprising since assertions aren't on release builds, right?

Can we just expectAssertions(0, 1) it on Linux instead of disabling the test?

    
    

    
      
  

    
    

    
      
  

    
    

    
  
In the last 7 days we have 32 failures.
They occur on Linux32, Linux x64, linux32-stylo-disabled, linux64-stylo-disabled, linux64-qr and the affected build type is debug.
Recent failure log example:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=167406442&lineNumber=4525

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #45)
Can we land the patch after we change it to debug only? (having in view comment #46)
Flags: needinfo?(jmaher)

    
    

    
  
Eliza would you want to edit the test case and add:
SimpleTest.expectAssertions(0, 1);

here is another test with that added to it:
https://searchfox.org/mozilla-central/source/accessible/tests/mochitest/events/test_flush.html#20

we would need to add that at the top of the file, probably right here:
https://searchfox.org/mozilla-central/source/toolkit/content/tests/widgets/test_videocontrols_standalone.html#15
Flags: needinfo?(jmaher) → needinfo?(ebalazs)

    
    

    
  


  
I edited the bug as requested. Please let me know if there is something else to add or change.
Flags: needinfo?(ebalazs) → needinfo?(jmaher)

        Attachment #8959073 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8959073 [details] [diff] [review]
Edited the test case

Review of attachment 8959073 [details] [diff] [review]:
-----------------------------------------------------------------

this looks good.

        Attachment #8959073 -
        Flags: review?(jmaher) → review+
Flags: needinfo?(jmaher)

    
    

    
      
  

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/02fa77a58ac1
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox61:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → ebalazs

          status-firefox48:
          affected → ---

          status-firefox59:
          --- → wontfix

          status-firefox60:
          --- → affected

          status-firefox-esr52:
          --- → wontfix

        Attachment #8954668 -
        Attachment is obsolete: true
Whiteboard: [stockwell unknown] → [stockwell disabled]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: