Closed Bug 1262739 Opened 4 years ago Closed 4 years ago

Remove support for splash_screens member in Manifest Processor

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: btpp-active)

Attachments

(1 file)

The screenshot member has been removed from the spec.
Blocks: webmanifest
Summary: Remove support for screenshot member in Manifest Processor → Remove support for splashscreen member in Manifest Processor
Err, I mean splashscreen
Summary: Remove support for splashscreen member in Manifest Processor → Remove support for splash_screens member in Manifest Processor
Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbe0df1a950b
Assignee: nobody → mcaceres
Status: NEW → ASSIGNED
Attachment #8738880 - Flags: review?(mconley)
Added dev-doc-needed in case the "splash_screens"member was document on MDN somewhere.
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/d335186c3be2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
We never documented this; we did mention the Chrome auto-generated Splashscreen feature, but that was it:

https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6)
> We never documented this; we did mention the Chrome auto-generated
> Splashscreen feature, but that was it:
> 
> https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens

I did a big rewrite of that document about two weeks ago. Maybe give it a once over?
Flags: needinfo?(cmills)
"that document" === the MDN page.
(In reply to Marcos Caceres [:marcosc] from comment #7)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6)
> > We never documented this; we did mention the Chrome auto-generated
> > Splashscreen feature, but that was it:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens
> 
> I did a big rewrite of that document about two weeks ago. Maybe give it a
> once over?

Sure — I've given it an edit, made the language more consistent, cleared up a few small grammar issues, and put the members in alphabetical order. One query I had - the description of the prefer_related_applications member is a bit vague:

"Specifies a boolean value that hints for the user agent to say that related applications (see below) should be preferred over the web application."

preferred in what context exactly? At what point would the related applications be chosen over the web application? I'm assuming "the web application" means the progressive web app the manifest is part of?
Flags: needinfo?(cmills)
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #9)
> (In reply to Marcos Caceres [:marcosc] from comment #7)
> > (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6)
> > > We never documented this; we did mention the Chrome auto-generated
> > > Splashscreen feature, but that was it:
> > > 
> > > https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens
> > 
> > I did a big rewrite of that document about two weeks ago. Maybe give it a
> > once over?
> 
> Sure — I've given it an edit, made the language more consistent, cleared up
> a few small grammar issues, and put the members in alphabetical order. One
> query I had - the description of the prefer_related_applications member is a
> bit vague:
> 
> "Specifies a boolean value that hints for the user agent to say that related
> applications (see below) should be preferred over the web application."
> 
> preferred in what context exactly? At what point would the related
> applications be chosen over the web application? I'm assuming "the web
> application" means the progressive web app the manifest is part of?


I know: it's insane - but it's what Google wanted :/ Basically, it's saying "don't install the web app, install the native app... unless you really want web app... but the ⭐️NATIVE APP⭐️  is better!".
(In reply to Marcos Caceres [:marcosc] from comment #10)
 
> I know: it's insane - but it's what Google wanted :/ Basically, it's saying
> "don't install the web app, install the native app... unless you really want
> web app... but the ⭐️NATIVE APP⭐️  is better!".

Oh. Ok. *shakes head*

I have updated the descriptions again, to make the purpose of these fields a bit clearer, and to include a bit of subtle dissuasion (without sounding too openly sarcastic).
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.