Closed
Bug 1262739
Opened 6 years ago
Closed 6 years ago
Remove support for splash_screens member in Manifest Processor
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: marcosc, Assigned: marcosc)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: btpp-active)
Attachments
(1 file)
2.63 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
The screenshot member has been removed from the spec.
Assignee | ||
Updated•6 years ago
|
Blocks: webmanifest
Assignee | ||
Updated•6 years ago
|
Summary: Remove support for screenshot member in Manifest Processor → Remove support for splashscreen member in Manifest Processor
Assignee | ||
Comment 1•6 years ago
|
||
Err, I mean splashscreen
Assignee | ||
Updated•6 years ago
|
Summary: Remove support for splashscreen member in Manifest Processor → Remove support for splash_screens member in Manifest Processor
Assignee | ||
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbe0df1a950b
Updated•6 years ago
|
Attachment #8738880 -
Flags: review?(mconley) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed,
dev-doc-needed
Assignee | ||
Comment 3•6 years ago
|
||
Added dev-doc-needed in case the "splash_screens"member was document on MDN somewhere.
Updated•6 years ago
|
Whiteboard: btpp-active
Comment 4•6 years ago
|
||
bugherderlanding |
https://hg.mozilla.org/integration/mozilla-inbound/rev/d335186c3be2
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d335186c3be2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 6•6 years ago
|
||
We never documented this; we did mention the Chrome auto-generated Splashscreen feature, but that was it: https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Comment 7•6 years ago
|
||
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6) > We never documented this; we did mention the Chrome auto-generated > Splashscreen feature, but that was it: > > https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens I did a big rewrite of that document about two weeks ago. Maybe give it a once over?
Flags: needinfo?(cmills)
Assignee | ||
Comment 8•6 years ago
|
||
"that document" === the MDN page.
Comment 9•6 years ago
|
||
(In reply to Marcos Caceres [:marcosc] from comment #7) > (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6) > > We never documented this; we did mention the Chrome auto-generated > > Splashscreen feature, but that was it: > > > > https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens > > I did a big rewrite of that document about two weeks ago. Maybe give it a > once over? Sure — I've given it an edit, made the language more consistent, cleared up a few small grammar issues, and put the members in alphabetical order. One query I had - the description of the prefer_related_applications member is a bit vague: "Specifies a boolean value that hints for the user agent to say that related applications (see below) should be preferred over the web application." preferred in what context exactly? At what point would the related applications be chosen over the web application? I'm assuming "the web application" means the progressive web app the manifest is part of?
Flags: needinfo?(cmills)
Assignee | ||
Comment 10•6 years ago
|
||
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #9) > (In reply to Marcos Caceres [:marcosc] from comment #7) > > (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6) > > > We never documented this; we did mention the Chrome auto-generated > > > Splashscreen feature, but that was it: > > > > > > https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens > > > > I did a big rewrite of that document about two weeks ago. Maybe give it a > > once over? > > Sure — I've given it an edit, made the language more consistent, cleared up > a few small grammar issues, and put the members in alphabetical order. One > query I had - the description of the prefer_related_applications member is a > bit vague: > > "Specifies a boolean value that hints for the user agent to say that related > applications (see below) should be preferred over the web application." > > preferred in what context exactly? At what point would the related > applications be chosen over the web application? I'm assuming "the web > application" means the progressive web app the manifest is part of? I know: it's insane - but it's what Google wanted :/ Basically, it's saying "don't install the web app, install the native app... unless you really want web app... but the ⭐️NATIVE APP⭐️ is better!".
Comment 11•6 years ago
|
||
(In reply to Marcos Caceres [:marcosc] from comment #10) > I know: it's insane - but it's what Google wanted :/ Basically, it's saying > "don't install the web app, install the native app... unless you really want > web app... but the ⭐️NATIVE APP⭐️ is better!". Oh. Ok. *shakes head* I have updated the descriptions again, to make the purpose of these fields a bit clearer, and to include a bit of subtle dissuasion (without sounding too openly sarcastic).
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•