1262739 - Remove support for splash_screens member in Manifest Processor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

The screenshot member has been removed from the spec.

Comment 1

[Marcos Caceres [:marcosc]]

Err, I mean splashscreen

Comment 2

[Marcos Caceres [:marcosc]]

Attachment: Removes splash_screens member and tests

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbe0df1a950b

Comment 3

[Marcos Caceres [:marcosc]]

Added dev-doc-needed in case the "splash_screens"member was document on MDN somewhere.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d335186c3be2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d335186c3be2

Comment 6

[Chris Mills [:cmills]]

We never documented this; we did mention the Chrome auto-generated Splashscreen feature, but that was it:

https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens

Comment 7

[Marcos Caceres [:marcosc]]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6)
> We never documented this; we did mention the Chrome auto-generated
> Splashscreen feature, but that was it:
> 
> https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens

I did a big rewrite of that document about two weeks ago. Maybe give it a once over?

Comment 8

[Marcos Caceres [:marcosc]]

"that document" === the MDN page.

Comment 9

[Chris Mills [:cmills]]

(In reply to Marcos Caceres [:marcosc] from comment #7)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6)
> > We never documented this; we did mention the Chrome auto-generated
> > Splashscreen feature, but that was it:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens
> 
> I did a big rewrite of that document about two weeks ago. Maybe give it a
> once over?

Sure — I've given it an edit, made the language more consistent, cleared up a few small grammar issues, and put the members in alphabetical order. One query I had - the description of the prefer_related_applications member is a bit vague:

"Specifies a boolean value that hints for the user agent to say that related applications (see below) should be preferred over the web application."

preferred in what context exactly? At what point would the related applications be chosen over the web application? I'm assuming "the web application" means the progressive web app the manifest is part of?

Comment 10

[Marcos Caceres [:marcosc]]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #9)
> (In reply to Marcos Caceres [:marcosc] from comment #7)
> > (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #6)
> > > We never documented this; we did mention the Chrome auto-generated
> > > Splashscreen feature, but that was it:
> > > 
> > > https://developer.mozilla.org/en-US/docs/Web/Manifest#Splash_screens
> > 
> > I did a big rewrite of that document about two weeks ago. Maybe give it a
> > once over?
> 
> Sure — I've given it an edit, made the language more consistent, cleared up
> a few small grammar issues, and put the members in alphabetical order. One
> query I had - the description of the prefer_related_applications member is a
> bit vague:
> 
> "Specifies a boolean value that hints for the user agent to say that related
> applications (see below) should be preferred over the web application."
> 
> preferred in what context exactly? At what point would the related
> applications be chosen over the web application? I'm assuming "the web
> application" means the progressive web app the manifest is part of?


I know: it's insane - but it's what Google wanted :/ Basically, it's saying "don't install the web app, install the native app... unless you really want web app... but the ⭐️NATIVE APP⭐️  is better!".

Comment 11

[Chris Mills [:cmills]]

(In reply to Marcos Caceres [:marcosc] from comment #10)
 
> I know: it's insane - but it's what Google wanted :/ Basically, it's saying
> "don't install the web app, install the native app... unless you really want
> web app... but the ⭐️NATIVE APP⭐️  is better!".

Oh. Ok. *shakes head*

I have updated the descriptions again, to make the purpose of these fields a bit clearer, and to include a bit of subtle dissuasion (without sounding too openly sarcastic).