1262766 - Storage Inspector breaks down when Cache Storage throws a DOM security error

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P1)

Description

[Jarda Snajdr [:jsnajdr]]

Steps to reproduce:
1. Open a private window
2. Go to any page
3. Open Storage Inspector

Cache storage is disabled in private mode, and calling any method on the CacheStorage object (e.g., cache.keys()) will throw a DOM security exception.

Expected result:
The storage inspector expects this error and recovers from it.

Actual result:
The uncaught exception prevents listing the stores from finishing, and the storage UI is not initialized properly. It becomes unusable, complaining about undefined properties all the time.

Comment 1

[Jarda Snajdr [:jsnajdr]]

Mike, I'm going to post a patch today, reassigning to me.

Comment 2

[Jarda Snajdr [:jsnajdr]]

Attachment: Storage Inspector breaks down when Cache Storage throws a DOM security error

Added a try/catch block when listing the caches for a host. The test is using an "untrusted" iframe which has a Javascript source URL - the CacheStorage is disabled for such iframes and a DOM security error is thrown.

Comment 3

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=56657d15a127

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8738977 [details] [diff] [review]
Storage Inspector breaks down when Cache Storage throws a DOM security error

Review of attachment 8738977 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on green try.

Comment 5

[Jarda Snajdr [:jsnajdr]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> r+ on green try.

The test started failing after the changes from bug 1237915 arrived to me. Filed that as bug 1262813.

Comment 6

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=71272d87b97b

Comment 7

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a61f0b897ce

Comment 8

[Jarda Snajdr [:jsnajdr]]

Attachment: Storage Inspector breaks down when Cache Storage throws a DOM security error

Added a workaround for bug 1262813 until it's properly fixed (or maybe this is the right fix?), try run was green with this new version of the patch.

Comment 9

[Jarda Snajdr [:jsnajdr]]

Attachment: Storage Inspector breaks down when Cache Storage throws a DOM security error

Fixed eslint errors.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/54a802cb5d43

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54a802cb5d43