Storage Inspector breaks down when Cache Storage throws a DOM security error

RESOLVED FIXED in Firefox 48

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: jsnajdr, Assigned: jsnajdr)

Tracking

Trunk
Firefox 48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

3 years ago
Steps to reproduce:
1. Open a private window
2. Go to any page
3. Open Storage Inspector

Cache storage is disabled in private mode, and calling any method on the CacheStorage object (e.g., cache.keys()) will throw a DOM security exception.

Expected result:
The storage inspector expects this error and recovers from it.

Actual result:
The uncaught exception prevents listing the stores from finishing, and the storage UI is not initialized properly. It becomes unusable, complaining about undefined properties all the time.
Assignee: nobody → mratcliffe
Priority: -- → P1
Assignee

Comment 1

3 years ago
Mike, I'm going to post a patch today, reassigning to me.
Assignee: mratcliffe → jsnajdr
Assignee

Comment 2

3 years ago
Added a try/catch block when listing the caches for a host. The test is using an "untrusted" iframe which has a Javascript source URL - the CacheStorage is disabled for such iframes and a DOM security error is thrown.
Attachment #8738977 - Flags: review?(mratcliffe)
Comment on attachment 8738977 [details] [diff] [review]
Storage Inspector breaks down when Cache Storage throws a DOM security error

Review of attachment 8738977 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on green try.
Attachment #8738977 - Flags: review?(mratcliffe) → review+
Assignee

Updated

3 years ago
Depends on: 1262813
Assignee

Comment 5

3 years ago
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> r+ on green try.

The test started failing after the changes from bug 1237915 arrived to me. Filed that as bug 1262813.
Assignee

Comment 8

3 years ago
Added a workaround for bug 1262813 until it's properly fixed (or maybe this is the right fix?), try run was green with this new version of the patch.
Attachment #8739784 - Flags: review?(mratcliffe)
Assignee

Updated

3 years ago
Attachment #8738977 - Attachment is obsolete: true
Assignee

Updated

3 years ago
Attachment #8739784 - Attachment is obsolete: true
Attachment #8739784 - Flags: review?(mratcliffe)
Attachment #8739874 - Flags: review?(mratcliffe) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/54a802cb5d43
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.