Closed Bug 1262781 Opened 8 years ago Closed 8 years ago

Update clang to 3.8.0 release

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

We're currently using a clang version from the development branch of 3.8, we should update to the actual release.
Depends on: 1262729, 1262735
Depends on: 1263080
The check is for the clang plugin, which is a host library. It is especially
important to use the host compiler for this check on OSX-on-Linux cross builds.

Review commit: https://reviewboard.mozilla.org/r/45683/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45683/
Attachment #8740268 - Flags: review?(nfroyd)
Attachment #8740269 - Flags: review?(nfroyd)
Ideally, we'd use the tarballs from
http://llvm.org/releases/download.html but I didn't feel like modifying
the script more than I already did to make it work at all (bug 1262735).

The new tarball for Linux was built on
https://tools.taskcluster.net/task-inspector/#LCUn8aEgTBeRJ11a3qTlDQ/0

The new tarball for Mac was built on a loaner, after installing cmake
and ninja, as well as building ld64 127.2 from source because the
installed version would assert while building clang. The latter required
manually adding some missing headers to /usr/include. TSAN was also
disabled because it requires APIs that are not available on the OSX
version on the build slaves (e.g. pthread_introspection_hook_install).
Building clang also required using a mac clang from tooltool, the system
one lacking support for atomics.

Review commit: https://reviewboard.mozilla.org/r/45685/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45685/
Comment on attachment 8740268 [details]
MozReview Request: Bug 1262781 - Use the host compiler for the ASTMatcher check. r?froydnj

https://reviewboard.mozilla.org/r/45683/#review42337
Attachment #8740268 - Flags: review?(nfroyd) → review+
Comment on attachment 8740269 [details]
MozReview Request: Bug 1262781 - Update to clang 3.8 final. r?froydnj

https://reviewboard.mozilla.org/r/45685/#review42339
Attachment #8740269 - Flags: review?(nfroyd) → review+
Blocks: 1295394
See Also: → 1295394
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.