Closed Bug 1262783 Opened 4 years ago Closed 4 years ago

Excessively cropped results in new Awesome Bar style

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: quicksaver, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

Attached image CroppedResults.jpg
Results seem to remain cropped after resizing the window. Meaning: results are successfully cropped further when shrinking the window, but they aren't "uncropped" after re-enlarging it.
Switching to UNCONFIRMED in case it was my fault somehow, until someone else confirms it at least.
Status: NEW → UNCONFIRMED
Ever confirmed: false
I can reproduce the problem.

https://hg.mozilla.org/mozilla-central/rev/68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 ID:20160406030221
STR
Reduce browser window width
Click Dropdown icon in locationbar
Enlarge  browser window width
Click Dropdown icon in locationbar
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P1
Whiteboard: [fxsearch]
Assignee: nobody → adw
Status: NEW → ASSIGNED
The problem happens for items that are completely reused when the popup is rebuilt.  In that case _adjustAcItem isn't called, so max-widths aren't removed and over/underflow isn't handled.

Review commit: https://reviewboard.mozilla.org/r/45073/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45073/
Attachment #8739151 - Flags: review?(mak77)
Attachment #8739151 - Flags: review?(mak77) → review+
Comment on attachment 8739151 [details]
MozReview Request: Bug 1262783 - Properly handle overflow/underflow for awesomebar items that are completely reused. r?mak

https://reviewboard.mozilla.org/r/45073/#review41585
https://hg.mozilla.org/mozilla-central/rev/ef57e33deb67
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.