1262783 - Excessively cropped results in new Awesome Bar style

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Luís Miguel [:quicksaver] (not reading bugmail)]

Attachment: CroppedResults.jpg

Results seem to remain cropped after resizing the window. Meaning: results are successfully cropped further when shrinking the window, but they aren't "uncropped" after re-enlarging it.

Comment 1

[Luís Miguel [:quicksaver] (not reading bugmail)]

Switching to UNCONFIRMED in case it was my fault somehow, until someone else confirms it at least.

Comment 2

[Alice0775 White]

I can reproduce the problem.

https://hg.mozilla.org/mozilla-central/rev/68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 ID:20160406030221

Comment 3

[Alice0775 White]

STR
Reduce browser window width
Click Dropdown icon in locationbar
Enlarge  browser window width
Click Dropdown icon in locationbar

Comment 4

[Drew Willcoxon :adw]

Attachment: MozReview Request: Bug 1262783 - Properly handle overflow/underflow for awesomebar items that are completely reused. r?mak

The problem happens for items that are completely reused when the popup is rebuilt.  In that case _adjustAcItem isn't called, so max-widths aren't removed and over/underflow isn't handled.

Review commit: https://reviewboard.mozilla.org/r/45073/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45073/

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92ebf86a3a93

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8739151 [details]
MozReview Request: Bug 1262783 - Properly handle overflow/underflow for awesomebar items that are completely reused. r?mak

https://reviewboard.mozilla.org/r/45073/#review41585

Comment 7

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/ef57e33deb67

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef57e33deb67