Downloads panel should only display overflow info on n+1 downloads

UNCONFIRMED
Unassigned

Status

()

Firefox
Downloads Panel
--
enhancement
UNCONFIRMED
a year ago
a year ago

People

(Reporter: Raphael Schweikert, Unassigned)

Tracking

45 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Created attachment 8738987 [details]
Screen Shot 2016-04-07 at 14.12.04.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160315153207

Steps to reproduce:

1. Download four files simultaneously.
2. Open the downloads panel.


Actual results:

There are three downloads displayed in the panel and then there is an additional item in the downloads list that is just a text saying there is “+ 1 other download“ (see screenshot).

Ask yourself: if it’s only one additional download and it takes up the same amount of space to display this notification, why not display the download directly?


Expected results:

The overflow notification item in the downloads list should only appear if limit+1 downloads are reached otherwise it needlessly takes up space.

So when there are four downloads, the panel should look as follows:

                     Λ      
┌───────────────────▕ ▏────┐
│┌───────────────────────┐ │
││      Download 1       │ │
│└───────────────────────┘ │
│┌───────────────────────┐ │
││      Download 1       │ │
│└───────────────────────┘ │
│┌───────────────────────┐ │
││      Download 1       │ │
│└───────────────────────┘ │
│┌───────────────────────┐ │
││      Download 1       │ │
│└───────────────────────┘ │
└──────────────────────────┘

And only when there are *five* downloads (limit+1) should the panel include the info text and hide the last two downloads (thus, still showing 4 items total):

                     Λ      
┌───────────────────▕ ▏────┐
│┌───────────────────────┐ │
││      Download 1       │ │
│└───────────────────────┘ │
│┌───────────────────────┐ │
││      Download 1       │ │
│└───────────────────────┘ │
│┌───────────────────────┐ │
││      Download 1       │ │
│└───────────────────────┘ │
│┌───────────────────────┐ │
││  + 2 other downloads  │ │
│└───────────────────────┘ │
└──────────────────────────┘
(Reporter)

Comment 1

a year ago
Oops, I forgot to number the downloads in the ASCII art above. I think you’ll get the gist. Also I took the liberty of labelling this a “good first bug” since I guess it’s trivial to fix.
Severity: normal → minor
Component: Untriaged → Downloads Panel
Whiteboard: good first bug
(Reporter)

Updated

a year ago
Whiteboard: good first bug → [good first bug]

Comment 2

a year ago
Hey, can I take this one?

Comment 3

a year ago
What files contain the modules responsible for this enhancement?

Comment 4

a year ago
Hai,can i work on this????

Comment 5

a year ago
Hi, I want to help. please involve me.

Updated

a year ago
Flags: needinfo?(sabberworm)

Comment 6

a year ago
Blake, who should take a look at this?
Severity: minor → enhancement
Flags: needinfo?(sabberworm) → needinfo?(bwinton)
Based on https://hg.mozilla.org/mozilla-central/filelog/c3f5e6079284a7b7053c41f05d0fe06ff031db03/browser/components/downloads/content/downloads.js I would probably choose one of :mak, :jaws, or :past…
Flags: needinfo?(bwinton)

Comment 8

a year ago
Putting past up to it.
Flags: needinfo?(past)
Actually, Paolo is the expert on the current downloads panel design. There is a redesign project underway for the downloads panel that may make this issue moot anyway, but at least he should know if this is something that has been considered already.
Flags: needinfo?(past) → needinfo?(paolo.mozmail)

Comment 10

a year ago
The diagrams in comment 0 don't take into account the "Show All Downloads" button. When there are four downloads, we don't add an item but we replace the button with the "overflow" indication. If we didn't do that, we would have to show the "Show All Downloads" button below the fourth download, which would take up more vertical space than the maximum we want.

The redesign project will probably make changes in this area, including the relative heights of the elements in the panel, so we can check if this still applies when the redesign is done.
Flags: needinfo?(paolo.mozmail)
Whiteboard: [good first bug]
(Reporter)

Comment 11

a year ago
(In reply to :Paolo Amadini from comment #10)
> The diagrams in comment 0 don't take into account the "Show All Downloads"
> button. When there are four downloads, we don't add an item but we replace
> the button with the "overflow" indication. If we didn't do that, we would
> have to show the "Show All Downloads" button below the fourth download,
> which would take up more vertical space than the maximum we want.

I did forget the “Show All Downloads” button but it takes up at most half the space of a complete item and I doubt 224px (current max height 144 + item height 80) is too much for any display currently in use.
I think that we should WONTFIX this bug due to the pending redesign tracked in bug 1269956. There is a nice UX sepc there that anyone can see and suggest improvements to. We are unlikely to work on any other changes to the downloads panel in parallel to that effort. Paolo, what do you think?
See Also: → bug 1269956

Comment 13

a year ago
The final call on interaction design for the new panel will be made by the user experience team, so as far as I can tell we should keep this suggestion for consideration until someone from the user experience team has looked at it.
You need to log in before you can comment on or make changes to this bug.