1262804 - Check API references get updated on deploy for all services

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Pete Moore [:pmoore][:pete]]

When deploying taskcluster-secrets in bug 1234826, the API references didn't get updated. Deploying a second time also didn't seem to fix it.

We don't currently understand why, and would like to:

a) find out why
b) check all other services, to make sure they don't have the same problem.

In case this is a problem with the library that deploys references, I'm filing this in Platform Libraries component.

Note, in bug 1234826 there were no schema changes, so we currently don't know if this was localised to references, or also affects schemas.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

ah, for secrets it appears to be an issue with env var name - TASKCLUSTER_PUBLISH_METADATA vs PUBLISH_METADATA.

However, from a peek at the source, it looks like queue never publishes.  I haven't checked any other services.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Also, it would be nice to have a way to check whether a reference is up-to-date.  Could they include the git hash or some other attribute?

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Secrets is updated now.

Here's an idea: in signature-validator-publisher, log a warning if publishing is disabled but NODE_ENV=production.

Comment 4

[Jonas Finnemann Jensen (:jonasfj)]

@pmoore, can we close this... I think all services except ec2-manager are publishing and we are changing how we publish anyways to use tc-lib-docs.

Comment 5

[Pete Moore [:pmoore][:pete]]

Indeed!

I think now the docs update is mostly a taskcluster-github integration, so we see a failed task if the docs update fails.

So I guess we are good. Thanks!