Closed Bug 1262812 Opened 5 years ago Closed 4 years ago
Clicking on a link in about:crashes doesn't do anything (JS error)
bug 1262812 - use fallback strings in CrashSubmit.jsm so submitting crashes from about:crashes works on Android.
59 bytes, text/x-review-board-request
We're looking for crashreporter.ini in the GRE directory: https://dxr.mozilla.org/mozilla-central/rev/68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8/toolkit/crashreporter/CrashSubmit.jsm#43 On Android this obviously doesn't exist, we'd need to pull it out of the APK instead. We can probably load it via a resource URL.
Comment on attachment 8870862 [details] bug 1262812 - use fallback strings in CrashSubmit.jsm so submitting crashes from about:crashes works on Android. https://reviewboard.mozilla.org/r/142430/#review146468 Tentative r+, assuming we're okay with about:crashes being en-US _only_ on Android. If we're not okay with that, we should probably put these fallback strings inside their own .properties file or something.
Attachment #8870862 - Flags: review?(mconley) → review+
(In reply to Mike Conley (:mconley) from comment #4) > Tentative r+, assuming we're okay with about:crashes being en-US _only_ on > Android. If we're not okay with that, we should probably put these fallback > strings inside their own .properties file or something. These strings aren't displayed in about:crashes, they're only written into the contents of the .txt files in the `Crash Reports/submitted` directory. There's no in-product UI to open those, we just read the filename and produce links to crash-stats.mo. On Android there's literally no way to access them without rooting your device, AFAIK.
After much fumbling around I was able to verify that this patch does allow me to tap an unsubmitted crash in about:crashes in Fennec and successfully submit it: https://crash-stats.mozilla.com/report/index/51d1f736-39bf-4307-b82a-2cd730170526
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/08caf9eba4e0 use fallback strings in CrashSubmit.jsm so submitting crashes from about:crashes works on Android. r=mconley
Device: Nexus 5 (Android 6.0.1) Verified as fixed in 55.0b3. When clicking on a link the user is redirected to the mozilla crash reports site. Marking as verified.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.