1262812 - Clicking on a link in about:crashes doesn't do anything (JS error)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Clicking on a link in about:crashes doesn't do anything in Nightly.

JavaScript error in log:
> GeckoConsole  E  [JavaScript Error: "not well-formed" {file: "https://crash-reports.mozilla.com/submit?id=%7Baa3c5121-dab2-40e2-81ca-7ea25febc110%7D&version=48.0a1&buildid=20160406030221" line: 1 column: 8 source: "CrashID=bp-9a6cc7f4-a7a1-401c-a79a-875c92160407"}]
> E  [JavaScript Error: "TypeError: strings is null" {file: "resource://gre/modules/CrashSubmit.jsm" line: 196}]

Comment 1

[(not currently active) Ted Mielczarek]

We're looking for crashreporter.ini in the GRE directory:
https://dxr.mozilla.org/mozilla-central/rev/68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8/toolkit/crashreporter/CrashSubmit.jsm#43

On Android this obviously doesn't exist, we'd need to pull it out of the APK instead. We can probably load it via a resource URL.

Comment 2

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2bfc3d83ed813421cb0c66589920442310f2cac4

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: bug 1262812 - use fallback strings in CrashSubmit.jsm so submitting crashes from about:crashes works on Android.

Review commit: https://reviewboard.mozilla.org/r/142430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142430/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8870862 [details]
bug 1262812 - use fallback strings in CrashSubmit.jsm so submitting crashes from about:crashes works on Android.

https://reviewboard.mozilla.org/r/142430/#review146468

Tentative r+, assuming we're okay with about:crashes being en-US _only_ on Android. If we're not okay with that, we should probably put these fallback strings inside their own .properties file or something.

Comment 5

[(not currently active) Ted Mielczarek]

(In reply to Mike Conley (:mconley) from comment #4)
> Tentative r+, assuming we're okay with about:crashes being en-US _only_ on
> Android. If we're not okay with that, we should probably put these fallback
> strings inside their own .properties file or something.

These strings aren't displayed in about:crashes, they're only written into the contents of the .txt files in the `Crash Reports/submitted` directory. There's no in-product UI to open those, we just read the filename and produce links to crash-stats.mo. On Android there's literally no way to access them without rooting your device, AFAIK.

Comment 6

[(not currently active) Ted Mielczarek]

After much fumbling around I was able to verify that this patch does allow me to tap an unsubmitted crash in about:crashes in Fennec and successfully submit it:
https://crash-stats.mozilla.com/report/index/51d1f736-39bf-4307-b82a-2cd730170526

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08caf9eba4e0
use fallback strings in CrashSubmit.jsm so submitting crashes from about:crashes works on Android. r=mconley

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/08caf9eba4e0

Comment 9

[Bogdan Surd, QA [:bsurd, NI]]

Device: Nexus 5 (Android 6.0.1)
Verified as fixed in 55.0b3. When clicking on a link the user is redirected to the mozilla crash reports site.
Marking as verified.