1262877 - Restore Previous Session disabled when close Firefox from "X" button

Status: RESOLVED WONTFIX

(Firefox :: Session Restore, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Attachment: Session Restore.7z

[Affected versions]:
- 48.0a1 (2016-04-07)
- 47.0a2 (2016-04-07)
- 46.0b8 build1 (20160404120533)
- 46.0b7 build2 (20160401021843)
- 45.0.1 (20160315153207)
- 45.0 build2 (20160303134406)
- 44.0 build3 (20160123151951)

[Affected platforms]:
- Mac OS X 10.11 
- Mac OS X 10.9

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Go to about:preferences.
3. On General tab, make sure that "When Firefox starts: Show my home page" option is chosen.
4. Open several random pages in different tabs.
5. Close Firefox by clicking the "X" button from the up-left window corner and the "Close Tabs" option (in the "Confirm Close" pop-up).
6. Restart Firefox with the same profile.

[Expected result]:
- Firefox restarts with the Mozilla Firefox Start Page and it contains the "Restore Previous Session" button.
- "Restore Previous Session" option is enabled in Hamburger Menu > History and in the History Toolbar Menu option.

[Actual result]:
- The user is unable to restore the previous session.

[Regression range]:
- I will check if this issue is a regression as soon as possible.

[Additional notes]:
- If "When Firefox starts: Show my windows and tabs from last time" option is chosen, the previous session isn`t restored when Firefox is closed from the "X" button and restarted, the start page being opened instead.

Comment 1

[Andrei Vaida [:avaida]]

[Tracking Requested - why for this release]:
A common scenario that's severely impacting the session restore feature.

Comment 2

[Daniel Veditz [:dveditz]]

Has this _ever_ worked on a Mac? Closing the last window doesn't close Firefox on Mac, and the session that is saved at that point will save the closed state of that window. Should be available on the History menu to open recently-closed windows.

Comment 3

[Daniel Veditz [:dveditz]]

What is the regression window on this? Should not mark something as a "regression" without a regression window.

Comment 4

[Andrei Vaida [:avaida]]

(In reply to Daniel Veditz [:dveditz] from comment #3)
> What is the regression window on this? Should not mark something as a
> "regression" without a regression window.

We're setting both [regression] and [regressionwindow-wanted] keywords for any bug we think might be a regression, as we don't always have enough time to dig deeper and determine that for sure. Our team uses this method because it's easier for us to keep track and follow up on all the new bugs that fall in this category.

Iulia is currently working on a regression range as we speak, so we should have this bug up to date in no time.

Comment 5

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Daniel Veditz [:dveditz] from comment #2)
> Has this _ever_ worked on a Mac? Closing the last window doesn't close
> Firefox on Mac, and the session that is saved at that point will save the
> closed state of that window. Should be available on the History menu to open
> recently-closed windows.

It seems that this behavior is indeed going all the way back to Fx4.0, so it's likely expected. I started from the assumption that the way this feature works should be on par with other browsers (e.g. Chromium based), where the user still has an option to restore his tabs after throwing them away by clicking the [x] window control button.

If this is not the case, then we can safely mark this bug as invalid.

Comment 6

[Romain Testard [:RT]]

I'm won't fix-ing this bug given that despite this behaviour being available since Firefox 4.0 we did not see other user reports and can safely assume that macOS users are not confused by our current implementations.