1262885 - Investigate performance impact of disabling e10s when d3d9 is enabled

Status: RESOLVED FIXED

(Core :: Graphics, defect, P4)

Description

[George Wright (:gw280) (needinfo me!)]

Follow up from bug 1237769

As per Jeff's comment:

"Milan: can we compare performance of two configurations of Firefox:

A) d3d9 is disabled, e10s is enabled
B) d3d9 is enabled, e10s is disabled


I want to know what performance trade-offs there are, if any."

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Right - not the highest urgency, as we know we're not regressing anything for the XP users at this point.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

here is a compare view of data for the disabling and the push prior:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=453f314bd7ae&newProject=mozilla-inbound&newRevision=a3f8a4e83cdd&framework=1&filter=xp

this is pretty much in-line with the alerts we recieved:
https://treeherder.mozilla.org/perf.html#/alerts?id=768

as this is just disabling e10s mode on certain OS/hardware configs, then we are not really seeing regressions.

maybe we need to ask ourselves how we can test e10s with d3d9 on windows xp?  or maybe this is a good sanity check for us?  with no d3d9, then e10s tests on windowsxp seems pointless.

Comment 3

[George Wright (:gw280) (needinfo me!)]

Joel, do the talos test machines get d3d9 in non-e10s? Are we comparing non-d3d9/e10s to d3d9/non-e10s or non-d3d9/e10s to non-d3d9/non-e10s here?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

the regression is non-d3d9/e10s <-> non-d3d9/non-e10s (the patch)

for non-e10s mode, I don't believe we have d3d9 available on the winxp machines currently.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

odd, this has made tart bi-modal on winxp e10s

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

with the landing of bug 1262954, all our perf changes here are reversed.  I would prefer to mark this as fixed.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Works for me.  We can reopen if/when it changes.