Closed Bug 1262917 Opened 6 years ago Closed 6 years ago

Do not try generate partials for new locales

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files, 1 obsolete file)

When we introduce an new locale, we have no previous build to build a partial against. In old process we ignore 404, see

https://dxr.mozilla.org/build-central/search?q=downloadUpdateIgnore404&redirect=false&case=true
Assignee: nobody → rail
Comment on attachment 8739168 [details]
MozReview Request: Bug 1262917 - Implement downloadUpdateIgnore404 in release promotion r=jlund a=release DONTBUILD

https://reviewboard.mozilla.org/r/45081/#review41603
Attachment #8739168 - Flags: review?(jlund) → review+
I didn't land this because it was something unfinished (would require some work to teach beetmover how to ignore 404s).

I think we shouldn't cargo cult the existing (implicit) solution and use something better (explicit). I'd rather to set an explicit names of locales to generate partials against. This has been bothering me today, so I couldn't stay away. :) Patches incoming.
Summary: Implement downloadUpdateIgnore404 in release promotion → Do not try generate partials for new locales
Attachment #8739168 - Attachment is obsolete: true
Attached file PR for releasetasks
Attachment #8739722 - Flags: review?(jlund)
I ran a test 46.0 release with 44.0 and 45.0 specified as partials.

"gn" was first introduced in 45.0, so we shouldn't try generating partials for 44.0->46.0, but for 45.0->46.0.


44.0->46.0: https://tools.taskcluster.net/task-inspector/#Ts6dZH7bR8id7AjS8WNwtg/0 - no "gn" \o/
45.0->46.0: https://tools.taskcluster.net/task-inspector/#-zl-Nk1bQHy354QBJXgg1g/0 - yes "gn" \o/
Comment on attachment 8739721 [details]
MozReview Request: Bug 1262917 - Do not try generate partials for new locales. r=jlund

https://reviewboard.mozilla.org/r/45349/#review42033

::: buildfarm/release/release-runner.py:216
(Diff revision 1)
> +            release['product'].capitalize(), partialVersion, buildNumber,
> +        )
>          partials[partialVersion] = {
>              'appVersion': getAppVersion(partialVersion),
>              'buildNumber': buildNumber,
> +            'locales': parsePlainL10nChangesets(

clever! love this approach :)
Attachment #8739721 - Flags: review?(jlund) → review+
Comment on attachment 8739721 [details]
MozReview Request: Bug 1262917 - Do not try generate partials for new locales. r=jlund

https://hg.mozilla.org/build/tools/rev/9b019b583d1c
Attachment #8739721 - Flags: checked-in+
Attachment #8739722 - Flags: review?(jlund)
Attachment #8739722 - Flags: review+
Attachment #8739722 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.