1262917 - Do not try generate partials for new locales

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

When we introduce an new locale, we have no previous build to build a partial against. In old process we ignore 404, see

https://dxr.mozilla.org/build-central/search?q=downloadUpdateIgnore404&redirect=false&case=true

Comment 1

[Rail Aliiev [:rail]]

see also https://tools.taskcluster.net/task-inspector/#7Mw6FnPTTuSS6DPEZG_qgA

Comment 2

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1262917 - Implement downloadUpdateIgnore404 in release promotion r=jlund a=release DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/45081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45081/

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8739168 [details]
MozReview Request: Bug 1262917 - Implement downloadUpdateIgnore404 in release promotion r=jlund a=release DONTBUILD

https://reviewboard.mozilla.org/r/45081/#review41603

Comment 4

[Rail Aliiev [:rail]]

I didn't land this because it was something unfinished (would require some work to teach beetmover how to ignore 404s).

I think we shouldn't cargo cult the existing (implicit) solution and use something better (explicit). I'd rather to set an explicit names of locales to generate partials against. This has been bothering me today, so I couldn't stay away. :) Patches incoming.

Comment 5

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1262917 - Do not try generate partials for new locales. r=jlund

Review commit: https://reviewboard.mozilla.org/r/45349/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45349/

Comment 6

[Rail Aliiev [:rail]]

Attachment: PR for releasetasks

Comment 7

[Rail Aliiev [:rail]]

I ran a test 46.0 release with 44.0 and 45.0 specified as partials.

"gn" was first introduced in 45.0, so we shouldn't try generating partials for 44.0->46.0, but for 45.0->46.0.


44.0->46.0: https://tools.taskcluster.net/task-inspector/#Ts6dZH7bR8id7AjS8WNwtg/0 - no "gn" \o/
45.0->46.0: https://tools.taskcluster.net/task-inspector/#-zl-Nk1bQHy354QBJXgg1g/0 - yes "gn" \o/

Comment 8

[Rail Aliiev [:rail]]

Also http://bucketlister-delivery.stage.mozaws.net/pub/firefox/candidates/46.0-candidates/build4/update/linux-x86_64/gn/ vs http://bucketlister-delivery.stage.mozaws.net/pub/firefox/candidates/46.0-candidates/build4/update/linux-x86_64/ach/

Comment 9

[Jordan Lund (:jlund)]

Comment on attachment 8739721 [details]
MozReview Request: Bug 1262917 - Do not try generate partials for new locales. r=jlund

https://reviewboard.mozilla.org/r/45349/#review42033

::: buildfarm/release/release-runner.py:216
(Diff revision 1)
> +            release['product'].capitalize(), partialVersion, buildNumber,
> +        )
>          partials[partialVersion] = {
>              'appVersion': getAppVersion(partialVersion),
>              'buildNumber': buildNumber,
> +            'locales': parsePlainL10nChangesets(

clever! love this approach :)

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 8739721 [details]
MozReview Request: Bug 1262917 - Do not try generate partials for new locales. r=jlund

https://hg.mozilla.org/build/tools/rev/9b019b583d1c