Do not try generate partials for new locales

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

3 years ago
When we introduce an new locale, we have no previous build to build a partial against. In old process we ignore 404, see

https://dxr.mozilla.org/build-central/search?q=downloadUpdateIgnore404&redirect=false&case=true
Assignee

Updated

3 years ago
Assignee: nobody → rail
Comment on attachment 8739168 [details]
MozReview Request: Bug 1262917 - Implement downloadUpdateIgnore404 in release promotion r=jlund a=release DONTBUILD

https://reviewboard.mozilla.org/r/45081/#review41603
Attachment #8739168 - Flags: review?(jlund) → review+
Assignee

Comment 4

3 years ago
I didn't land this because it was something unfinished (would require some work to teach beetmover how to ignore 404s).

I think we shouldn't cargo cult the existing (implicit) solution and use something better (explicit). I'd rather to set an explicit names of locales to generate partials against. This has been bothering me today, so I couldn't stay away. :) Patches incoming.
Summary: Implement downloadUpdateIgnore404 in release promotion → Do not try generate partials for new locales
Assignee

Updated

3 years ago
Attachment #8739168 - Attachment is obsolete: true
Assignee

Comment 6

3 years ago
Posted file PR for releasetasks
Attachment #8739722 - Flags: review?(jlund)
Assignee

Comment 7

3 years ago
I ran a test 46.0 release with 44.0 and 45.0 specified as partials.

"gn" was first introduced in 45.0, so we shouldn't try generating partials for 44.0->46.0, but for 45.0->46.0.


44.0->46.0: https://tools.taskcluster.net/task-inspector/#Ts6dZH7bR8id7AjS8WNwtg/0 - no "gn" \o/
45.0->46.0: https://tools.taskcluster.net/task-inspector/#-zl-Nk1bQHy354QBJXgg1g/0 - yes "gn" \o/
Comment on attachment 8739721 [details]
MozReview Request: Bug 1262917 - Do not try generate partials for new locales. r=jlund

https://reviewboard.mozilla.org/r/45349/#review42033

::: buildfarm/release/release-runner.py:216
(Diff revision 1)
> +            release['product'].capitalize(), partialVersion, buildNumber,
> +        )
>          partials[partialVersion] = {
>              'appVersion': getAppVersion(partialVersion),
>              'buildNumber': buildNumber,
> +            'locales': parsePlainL10nChangesets(

clever! love this approach :)
Attachment #8739721 - Flags: review?(jlund) → review+
Assignee

Comment 10

3 years ago
Comment on attachment 8739721 [details]
MozReview Request: Bug 1262917 - Do not try generate partials for new locales. r=jlund

https://hg.mozilla.org/build/tools/rev/9b019b583d1c
Attachment #8739721 - Flags: checked-in+
Assignee

Updated

3 years ago
Attachment #8739722 - Flags: review?(jlund)
Attachment #8739722 - Flags: review+
Attachment #8739722 - Flags: checked-in+
Assignee

Updated

3 years ago
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.