1262950 - crmftest not being run in "recover" or "challenge" mode

Status: RESOLVED WONTFIX

(NSS :: Test, enhancement, P5)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

cmd/crmftest has a corresponding test script in tests/crmf/crmf.sh, but some of its code isn't reached, because the "recover" and "challenge" keywords aren't used.  Apparently "recover" was never quite finished, but "challenge" is being built and not run.  Relevant pieces of coverage-annotated source (see bug 1251089): 

[#]    1495     } else if (!strcmp(arg, "decode")) {
[#]    1496     	*flags |= TEST_DECODE_CRMF_REQ;
[#]    1497     } else if (!strcmp(arg, "cmmf")) {
[#]    1498     	*flags |= TEST_DO_CMMF_STUFF;
[.]    1499     } else if (!strcmp(arg, "recover")) {
[.]    1500     	*flags |= TEST_KEY_RECOVERY;
[.]    1501     } else if (!strcmp(arg, "challenge")) {
[.]    1502     	*flags |= TEST_CHALLENGE_RESPONSE;


[#]    1629     if (flags & TEST_KEY_RECOVERY) {
       1630 	/* Requires some other options be set.
       1631 	** Once we know exactly what hey are, test for them here. 
       1632 	*/
[.]    1633 	printf("Doing Key Recovery\n");
       1634 	irv = DoKeyRecovery(WHICH_KEY.privKey);

[#]    1641     if (flags & TEST_CHALLENGE_RESPONSE) {
[.]    1642 	printf("Doing Challenge / Response\n");
       1643 	irv = DoChallengeResponse(WHICH_KEY.privKey, WHICH_KEY.pubKey);


        946 int
        947 DoKeyRecovery( SECKEYPrivateKey *privKey)
[.]     948 {
        949 #ifdef DOING_KEY_RECOVERY  /* Doesn't compile yet. */

       1181 int
       1182 DoChallengeResponse(SECKEYPrivateKey *privKey,
       1183 		    SECKEYPublicKey *pubKey)
[.]    1184 {

There's a comment at the top of the file, added in 2004, which notes:

 * 4. Key Recovery
 *	This code does not yet compile, and what it was intended to do
 *	has not been fully determined.
 *
 * 5. Challenge/Response.
 *	Haven't analyzed this code yet.