Closed Bug 1263031 Opened 5 years ago Closed 5 years ago

update browser_save_private_link_perwindowpb.js to use BrowserTestUtils

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
46 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

Attachments

(1 file, 1 obsolete file)

modernize and clarify test
8.56 KB, patch
mixedpuppy
: review+
Details | Diff | Splinter Review
Attached patch modernize and clarify test (obsolete) — — Splinter Review 
While trying to determine where a linux-debug-only-leak was happening (triggered by the test being updated) I rewrote this test to make it understandable.  Ultimately the the change is not necessary to fix the leak, but this is definitely more readable than before.
Attachment #8739254 - Attachment is patch: true
Attachment #8739254 - Attachment mime type: text/x-patch → text/plain
Attachment #8739254 - Flags: review?(jaws)
Assignee: nobody → mixedpuppy
Status: NEW → ASSIGNED
Summary: update test to use browsertestutils → update browser_save_private_link_perwindowpb.js to use BrowserTestUtils
Comment on attachment 8739254 [details] [diff] [review]
modernize and clarify test

Review of attachment 8739254 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_save_private_link_perwindowpb.js
@@ +50,4 @@
>  
> +    function onTransferComplete(downloadSuccess) {
> +      ok(downloadSuccess, "Image file should have been downloaded successfully ");
> +  

nit, trailing whitespace

@@ +81,5 @@
>  }
>  
> +add_task(function* () {
> +  let testURI = "http://mochi.test:8888/browser/browser/base/content/test/general/bug792517.html";
> +  let newwindow = yield BrowserTestUtils.openNewBrowserWindow({private: true});

s/newwindow/privateWindow/
Attachment #8739254 - Flags: review?(jaws) → review+
comments addressed and previous failure fixed by reverting the cache checking to what it was before.  carrying forward r+
Attachment #8739254 - Attachment is obsolete: true
Attachment #8743490 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/4e06b7965443
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.