Closed
Bug 1263031
Opened 8 years ago
Closed 8 years ago
update browser_save_private_link_perwindowpb.js to use BrowserTestUtils
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
Details
Attachments
(1 file, 1 obsolete file)
8.56 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
While trying to determine where a linux-debug-only-leak was happening (triggered by the test being updated) I rewrote this test to make it understandable. Ultimately the the change is not necessary to fix the leak, but this is definitely more readable than before.
Assignee | ||
Updated•8 years ago
|
Attachment #8739254 -
Attachment is patch: true
Attachment #8739254 -
Attachment mime type: text/x-patch → text/plain
Assignee | ||
Updated•8 years ago
|
Attachment #8739254 -
Flags: review?(jaws)
Updated•8 years ago
|
Assignee: nobody → mixedpuppy
Status: NEW → ASSIGNED
Summary: update test to use browsertestutils → update browser_save_private_link_perwindowpb.js to use BrowserTestUtils
Comment 1•8 years ago
|
||
Comment on attachment 8739254 [details] [diff] [review] modernize and clarify test Review of attachment 8739254 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/general/browser_save_private_link_perwindowpb.js @@ +50,4 @@ > > + function onTransferComplete(downloadSuccess) { > + ok(downloadSuccess, "Image file should have been downloaded successfully "); > + nit, trailing whitespace @@ +81,5 @@ > } > > +add_task(function* () { > + let testURI = "http://mochi.test:8888/browser/browser/base/content/test/general/bug792517.html"; > + let newwindow = yield BrowserTestUtils.openNewBrowserWindow({private: true}); s/newwindow/privateWindow/
Attachment #8739254 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/105e0e4b9d800048ff535543b0c5f01919612a3c Bug 1263031 modernize and clarify test, r=jaws
Comment 3•8 years ago
|
||
Windows says: https://treeherder.mozilla.org/logviewer.html#?job_id=8586313&repo=fx-team Backed out in https://hg.mozilla.org/integration/fx-team/rev/711691554872
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eddefbd9b692
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3075775fc04
Assignee | ||
Comment 6•8 years ago
|
||
comments addressed and previous failure fixed by reverting the cache checking to what it was before. carrying forward r+
Attachment #8739254 -
Attachment is obsolete: true
Attachment #8743490 -
Flags: review+
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4e06b79654439c156c079d58892c989faa18a227 Bug 1263031 modernize and clarify test, r=jaws
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4e06b7965443
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•