1263031 - update browser_save_private_link_perwindowpb.js to use BrowserTestUtils

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Attachment: modernize and clarify test

While trying to determine where a linux-debug-only-leak was happening (triggered by the test being updated) I rewrote this test to make it understandable.  Ultimately the the change is not necessary to fix the leak, but this is definitely more readable than before.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8739254 [details] [diff] [review]
modernize and clarify test

Review of attachment 8739254 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_save_private_link_perwindowpb.js
@@ +50,4 @@
>  
> +    function onTransferComplete(downloadSuccess) {
> +      ok(downloadSuccess, "Image file should have been downloaded successfully ");
> +  

nit, trailing whitespace

@@ +81,5 @@
>  }
>  
> +add_task(function* () {
> +  let testURI = "http://mochi.test:8888/browser/browser/base/content/test/general/bug792517.html";
> +  let newwindow = yield BrowserTestUtils.openNewBrowserWindow({private: true});

s/newwindow/privateWindow/

Comment 2

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/105e0e4b9d800048ff535543b0c5f01919612a3c
Bug 1263031  modernize and clarify test, r=jaws

Comment 3

[Phil Ringnalda (:philor)]

Windows says: https://treeherder.mozilla.org/logviewer.html#?job_id=8586313&repo=fx-team

Backed out in https://hg.mozilla.org/integration/fx-team/rev/711691554872

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eddefbd9b692

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3075775fc04

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: modernize and clarify test

comments addressed and previous failure fixed by reverting the cache checking to what it was before.  carrying forward r+

Comment 7

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/4e06b79654439c156c079d58892c989faa18a227
Bug 1263031 modernize and clarify test, r=jaws

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e06b7965443