Closed
Bug 1263032
Opened 6 years ago
Closed 6 years ago
turn on pocket tests
Categories
(Firefox :: Pocket, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
People
(Reporter: mixedpuppy, Unassigned)
Details
Attachments
(1 file)
17.02 KB,
patch
|
markh
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
This turns on pocket during test runs. It introduces some pocket specifics into some tests, particularly the context menu tests.
Reporter | ||
Updated•6 years ago
|
Attachment #8739255 -
Attachment is patch: true
Reporter | ||
Comment 1•6 years ago
|
||
Comment on attachment 8739255 [details] [diff] [review] turn on pocket addon during tests https://treeherder.mozilla.org/#/jobs?repo=try&revision=a83b687435dc
Attachment #8739255 -
Flags: review?(markh)
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 8739255 [details] [diff] [review] turn on pocket addon during tests or Gijs
Attachment #8739255 -
Flags: review?(gijskruitbosch+bugs)
Comment 3•6 years ago
|
||
Comment on attachment 8739255 [details] [diff] [review] turn on pocket addon during tests Review of attachment 8739255 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8739255 -
Flags: review?(markh)
Attachment #8739255 -
Flags: review?(gijskruitbosch+bugs)
Attachment #8739255 -
Flags: review+
Comment 4•6 years ago
|
||
Comment on attachment 8739255 [details] [diff] [review] turn on pocket addon during tests Review of attachment 8739255 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/general/contextmenu_common.js @@ +61,5 @@ > items.push("+" + label); > } else if (item.id.indexOf("spell-check-dictionary-") != 0 && > item.id != "spell-no-suggestions" && > item.id != "spell-add-dictionaries-main" && > + item.id != "context-savelinktopocket" && can you file a followup bug to give it an access key?
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #4) > ----------------------------------------------------------------- > > ::: browser/base/content/test/general/contextmenu_common.js > @@ +61,5 @@ > > items.push("+" + label); > > } else if (item.id.indexOf("spell-check-dictionary-") != 0 && > > item.id != "spell-no-suggestions" && > > item.id != "spell-add-dictionaries-main" && > > + item.id != "context-savelinktopocket" && > > can you file a followup bug to give it an access key? It does have an access key. iirc I couldn't find a free unique access key across all platforms, I left the access key as-is and just removed this item from the access key test.
Reporter | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1e17a83bd0d7767cdf89eb11a78ef572d6c427bf Bug 1263032 turn on pocket addon during tests, r=markh
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1e17a83bd0d7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Reporter | ||
Comment 8•6 years ago
|
||
Comment on attachment 8739255 [details] [diff] [review] turn on pocket addon during tests Approval Request Comment [Feature/regressing bug #]:pocket [User impact if declined]:less test coverage to verify errors/fixes [Describe test coverage new/current, TreeHerder]:turning on new test coverage [Risks and why]: low, only a couple small fixes for tests [String/UUID change made/needed]:none
Attachment #8739255 -
Flags: approval-mozilla-aurora?
Comment 9•6 years ago
|
||
Confirming that this made the Pocket button show up in mochitest-browser-chrome as seen in the Nightly screenshot comparision: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=d9b1a9829c8ee2862955043f28183efa07de3d2b&newProject=mozilla-central&newRev=705c5fb32d49de2c09b564aa5ff8e8edf1be85ae
Comment 10•6 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #9) > Confirming that this made the Pocket button show up in > mochitest-browser-chrome as seen in the Nightly screenshot comparision: > https://screenshots.mattn.ca/compare/?oldProject=mozilla- > central&oldRev=d9b1a9829c8ee2862955043f28183efa07de3d2b&newProject=mozilla- > central&newRev=705c5fb32d49de2c09b564aa5ff8e8edf1be85ae I've looked before when you previously mentioned this tool, but gotta say it out loud this time - that's really awesome!
Comment 11•6 years ago
|
||
Thanks! I hope to get it automatically posting results somewhere (e.g. like telemetry and talos alerts) in the not too distant future. There's a lot more low hanging fruit to make things better: https://public.etherpad-mozilla.org/p/mozscreenshots
status-firefox47:
--- → affected
Comment on attachment 8739255 [details] [diff] [review] turn on pocket addon during tests Automated tests for Pocket, Aurora47+
Attachment #8739255 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/e956f6247d51
You need to log in
before you can comment on or make changes to this bug.
Description
•