1263032 - turn on pocket tests

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Attachment: turn on pocket addon during tests

This turns on pocket during test runs.  It introduces some pocket specifics into some tests, particularly the context menu tests.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8739255 [details] [diff] [review]
turn on pocket addon during tests

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a83b687435dc

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8739255 [details] [diff] [review]
turn on pocket addon during tests

or Gijs

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8739255 [details] [diff] [review]
turn on pocket addon during tests

Review of attachment 8739255 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 4

[:Gijs (he/him)]

Comment on attachment 8739255 [details] [diff] [review]
turn on pocket addon during tests

Review of attachment 8739255 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/contextmenu_common.js
@@ +61,5 @@
>                items.push("+" + label);
>              } else if (item.id.indexOf("spell-check-dictionary-") != 0 &&
>                         item.id != "spell-no-suggestions" &&
>                         item.id != "spell-add-dictionaries-main" &&
> +                       item.id != "context-savelinktopocket" &&

can you file a followup bug to give it an access key?

Comment 5

[Shane Caraveo (:mixedpuppy)]

(In reply to :Gijs Kruitbosch from comment #4)
> -----------------------------------------------------------------
> 
> ::: browser/base/content/test/general/contextmenu_common.js
> @@ +61,5 @@
> >                items.push("+" + label);
> >              } else if (item.id.indexOf("spell-check-dictionary-") != 0 &&
> >                         item.id != "spell-no-suggestions" &&
> >                         item.id != "spell-add-dictionaries-main" &&
> > +                       item.id != "context-savelinktopocket" &&
> 
> can you file a followup bug to give it an access key?

It does have an access key.  iirc I couldn't find a free unique access key across all platforms, I left the access key as-is and just removed this item from the access key test.

Comment 6

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/1e17a83bd0d7767cdf89eb11a78ef572d6c427bf
Bug 1263032 turn on pocket addon during tests, r=markh

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1e17a83bd0d7

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8739255 [details] [diff] [review]
turn on pocket addon during tests

Approval Request Comment
[Feature/regressing bug #]:pocket
[User impact if declined]:less test coverage to verify errors/fixes
[Describe test coverage new/current, TreeHerder]:turning on new test coverage
[Risks and why]: low, only a couple small fixes for tests
[String/UUID change made/needed]:none

Comment 9

[Matthew N. [:MattN]]

Confirming that this made the Pocket button show up in mochitest-browser-chrome as seen in the Nightly screenshot comparision: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=d9b1a9829c8ee2862955043f28183efa07de3d2b&newProject=mozilla-central&newRev=705c5fb32d49de2c09b564aa5ff8e8edf1be85ae

Comment 10

[Mark Hammond [:markh] [:mhammond]]

(In reply to Matthew N. [:MattN] from comment #9)
> Confirming that this made the Pocket button show up in
> mochitest-browser-chrome as seen in the Nightly screenshot comparision:
> https://screenshots.mattn.ca/compare/?oldProject=mozilla-
> central&oldRev=d9b1a9829c8ee2862955043f28183efa07de3d2b&newProject=mozilla-
> central&newRev=705c5fb32d49de2c09b564aa5ff8e8edf1be85ae

I've looked before when you previously mentioned this tool, but gotta say it out loud this time - that's really awesome!

Comment 11

[Matthew N. [:MattN]]

Thanks! I hope to get it automatically posting results somewhere (e.g. like telemetry and talos alerts) in the not too distant future.  There's a lot more low hanging fruit to make things better: https://public.etherpad-mozilla.org/p/mozscreenshots

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8739255 [details] [diff] [review]
turn on pocket addon during tests

Automated tests for Pocket, Aurora47+

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e956f6247d51