Closed
Bug 1263053
Opened 8 years ago
Closed 8 years ago
BasicCompositor on OS X is using sync transactions
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: mstange, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
1.15 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
Sync transactions are bad. I noticed this on https://www.just-eat.ca/restaurants-casa-di-giorgio-queen-east/menu?opt=0a765732 because the sidebars were jittering much more than they need to.
Assignee | ||
Comment 1•8 years ago
|
||
:mstange, is it BasicCompositor specific problem?
Flags: needinfo?(mstange)
Reporter | ||
Comment 2•8 years ago
|
||
Yes. It looks like we're not using tiles when BasicCompositor is used. Using tiles might fix both this bug and bug 1262863.
Flags: needinfo?(mstange)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8741244 -
Flags: review?(nical.bugzilla)
Comment 4•8 years ago
|
||
Comment on attachment 8741244 [details] [diff] [review] patch - Enable tiling on BasicCompositor Review of attachment 8741244 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/ClientPaintedLayer.cpp @@ +164,5 @@ > #ifndef MOZ_X11 > && (AsShadowForwarder()->GetCompositorBackendType() == LayersBackend::LAYERS_OPENGL || > AsShadowForwarder()->GetCompositorBackendType() == LayersBackend::LAYERS_D3D9 || > + AsShadowForwarder()->GetCompositorBackendType() == LayersBackend::LAYERS_D3D11 || > + AsShadowForwarder()->GetCompositorBackendType() == LayersBackend::LAYERS_BASIC) That's about all of the backends so you can just remove the whole #ifndef block!
Attachment #8741244 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Yea, I am going to update the patch.
Assignee | ||
Comment 6•8 years ago
|
||
Apply the comment. Carry "r=nical".
Attachment #8741244 -
Attachment is obsolete: true
Attachment #8741603 -
Flags: review+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70ec09a17094
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Flags: needinfo?(sotaro.ikeda.g)
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Flags: needinfo?(sotaro.ikeda.g)
Resolution: FIXED → ---
Assignee | ||
Updated•8 years ago
|
Keywords: leave-open
Assignee | ||
Comment 10•8 years ago
|
||
:BenWa, is it better to back out until bug 1265873 is addressed?
Flags: needinfo?(bgirard)
Comment 11•8 years ago
|
||
We're uplifting this coming Monday so I think it is better to back this out and reland with the fix at the start of the next cycle. Unless we measured a good performance win for this patch but I don't see any Talos improvement notices.
Flags: needinfo?(bgirard)
Reporter | ||
Comment 12•8 years ago
|
||
We're not running Talos with BasicCompositor on OS X.
Assignee | ||
Comment 13•8 years ago
|
||
It seems better to backout to prevent regression.
Assignee | ||
Comment 15•8 years ago
|
||
backout is in aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/fa784f0160f0
Assignee | ||
Comment 16•8 years ago
|
||
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=8850ff6c53b3&newProject=try&newRevision=b9585336a3ef&framework=1&showOnlyImportant=0
Assignee | ||
Updated•8 years ago
|
Keywords: leave-open
Comment 18•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3bc29971aa0a
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Release Note Request (optional, but appreciated) [Why is this notable]: [Suggested wording]: Improve overall performance on OS X systems without hardware acceleration. [Links (documentation, blog post, etc)]:
relnote-firefox:
--- → ?
Comment 20•8 years ago
|
||
49+ for relnote - added "Improve overall performance on OS X systems without hardware acceleration"
Comment 21•8 years ago
|
||
Milan, do we have numbers about that? Are we talking about 2% or 20? thanks
Flags: needinfo?(milan)
Assignee | ||
Comment 22•8 years ago
|
||
By comment 15, it was backed out from firefox 48.
But it's still in 49, right?
Flags: needinfo?(milan) → needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 24•8 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #23) > But it's still in 49, right? Yes. It was checked in again by Comment 18.
Flags: needinfo?(sotaro.ikeda.g)
You need to log in
before you can comment on or make changes to this bug.
Description
•