1263074 - Change the JavaScript syntax error message for the old octal literal notation to suggest the new notation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jonathan Watt [:jwatt]]

Using the old "0" prefixed octal literal notation results in:

  SyntaxError: octal literals and octal escape sequences are deprecated

We now have the new "0o" prefixed octal literal notation though, so this error message is somewhat misleading.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8739303 [details] [diff] [review]
patch

Forwarding to someone who I recall saying "octal" a lot a while ago...

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8739303 [details] [diff] [review]
patch

Review of attachment 8739303 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I thought about doing this when octal literals were added but decided it was a bit early to suggest it.  A couple years later, this seems much safer.

::: js/src/js.msg
@@ +237,5 @@
>  MSG_DEF(JSMSG_DEPRECATED_DELETE_OPERAND, 0, JSEXN_SYNTAXERR, "applying the 'delete' operator to an unqualified name is deprecated")
>  MSG_DEF(JSMSG_DEPRECATED_EXPR_CLOSURE, 0, JSEXN_NONE, "expression closures are deprecated")
>  MSG_DEF(JSMSG_DEPRECATED_FLAGS_ARG,    0, JSEXN_NONE, "flags argument of String.prototype.{search,match,replace} is deprecated")
>  MSG_DEF(JSMSG_DEPRECATED_FOR_EACH,     0, JSEXN_NONE, "JavaScript 1.6's for-each-in loops are deprecated; consider using ES6 for-of instead")
> +MSG_DEF(JSMSG_DEPRECATED_OCTAL,        0, JSEXN_SYNTAXERR, "\"0\" prefixed octal literals and octal escape sequences are deprecated; for octal literals use the \"0o\" prefix instead")

"0"-prefixed, maybe?  Adjectival phrase or something.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e461f39cc00

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2e461f39cc00