Closed
Bug 1263094
Opened 8 years ago
Closed 8 years ago
IonMonkey: MIPS: Change members to non-virtual in CodeGenerator
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
Details
Attachments
(1 file)
2.56 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
IIRC, If child-class deson't need override member functions, call non-vritual function fast than virtual? MIPS32: void visitCompareB(LCompareB* lir); void visitCompareBAndBranch(LCompareBAndBranch* lir); void visitCompareBitwise(LCompareBitwise* lir); void visitCompareBitwiseAndBranch(LCompareBitwiseAndBranch* lir); MIPS64: void visitCompareB(LCompareB* lir); void visitCompareBAndBranch(LCompareBAndBranch* lir); void visitCompareBitwise(LCompareBitwise* lir); void visitCompareBitwiseAndBranch(LCompareBitwiseAndBranch* lir); void visitAsmSelectI64(LAsmSelectI64* ins); void visitAsmReinterpretFromI64(LAsmReinterpretFromI64* lir); void visitAsmReinterpretToI64(LAsmReinterpretToI64* lir);
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8739324 -
Flags: review?(arai.unmht)
Comment 2•8 years ago
|
||
Comment on attachment 8739324 [details] [diff] [review] 0001-Bug-1263094-IonMonkey-MIPS-Change-members-to-non-vir.patch Review of attachment 8739324 [details] [diff] [review]: ----------------------------------------------------------------- Would be better applying same change to arm/arm64 as well :)
Attachment #8739324 -
Flags: review?(arai.unmht) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d0c1dd4e37a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•