Closed Bug 1263156 Opened 6 years ago Closed 6 years ago

"Cannot add 'AVAHI_CFLAGS' to configuration: Key already exists" configure error

Categories

(Instantbird :: Other, defect)

Unspecified
Linux
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 48

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8739428 [details] [diff] [review]
Fix "Cannot add 'AVAHI_CFLAGS' to configuration: Key already exists" configure error

Can you check if this works on a local build as well? Thanks.
Attachment #8739428 - Flags: feedback?(ab)
Comment on attachment 8739428 [details] [diff] [review]
Fix "Cannot add 'AVAHI_CFLAGS' to configuration: Key already exists" configure error

Review of attachment 8739428 [details] [diff] [review]:
-----------------------------------------------------------------

It did not work on local build and this is the error
> 0:09.39 /home/abdelrhman/mozilla/comm-central/mozilla/old-configure: 21673: test: Illegal number:
> 0:09.40 /home/abdelrhman/mozilla/comm-central/mozilla/old-configure: 21733: test: Illegal number:
> 0:09.40 checking for wget... wget
> 0:09.46 checking for valid C compiler optimization flags... yes
> 0:09.57 /home/abdelrhman/mozilla/comm-central/mozilla/old-configure: 179: /tmp/subscript.YJkBcj: Syntax error: word unexpected (expecting ")")
Attachment #8739428 - Flags: feedback?(ab) → feedback-
Comment on attachment 8739428 [details] [diff] [review]
Fix "Cannot add 'AVAHI_CFLAGS' to configuration: Key already exists" configure error

Review of attachment 8739428 [details] [diff] [review]:
-----------------------------------------------------------------

r=me without the AC_SUBST_LIST changes.

::: configure.in
@@ +158,5 @@
>              ifelse([$4], ,echo $$1_PKG_ERRORS,)
>          fi
>  
> +        AC_SUBST_LIST($1_CFLAGS)
> +        AC_SUBST_LIST($1_LIBS)

This change is what causes the error in comment 3.
Attachment #8739428 - Flags: review?(florian) → review+
Severity: normal → critical
https://hg.mozilla.org/users/florian_queze.net/purple/rev/747fd3ff1c0b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
You need to log in before you can comment on or make changes to this bug.