1263162 - TelemetryEnvironment should not detect addon changes until after addons are cached

Status: NEW

(Toolkit :: Telemetry, defect, P4)

Description

[Georg Fritzsche [:gfritzsche]]

The change detection condition here looks wrong:
https://dxr.mozilla.org/mozilla-central/rev/b6683e141c47c022598c0caac3ea8ba8c6236d42/toolkit/components/telemetry/TelemetryEnvironment.jsm#509

We should actually not detect a change until we actually have the addons list loaded/cached and finished the environment initialization.

We should make this into:
!!this._environment._currentEnvironment.addons &&
!ObjectUtils.deepEqual(addons, this._environment._currentEnvironment.addons)

There may be test fallout from this though, we also have to check that the crash annotation doesn't break:
https://dxr.mozilla.org/mozilla-central/rev/b6683e141c47c022598c0caac3ea8ba8c6236d42/toolkit/components/telemetry/TelemetryStartup.js#35,45