Closed Bug 1263174 Opened 5 years ago Closed 5 years ago

<span class='hostname'/> does not work in entity certerror.introPara

Categories

(Firefox :: General, defect)

48 Branch
All
Windows 10
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: leichixian, Assigned: Gijs)

References

()

Details

(Keywords: regression)

Attachments

(2 files)

Attached image No hostname
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160408030212

Steps to reproduce:

Try to visit a site with wrong cert (Here I use https://www.firefox.net.cn/)
2. 


Actual results:

The hostname is not shown.


Expected results:

The page will give out a warning like the screenshot, where the text under "your connect is not secure should be the entity "certerror.introPara" from \browser\chrome\zh-CN\locale\browser\netError.dtd (or other local pack). Then the <span class='hostname'/> text should be shown.
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8&tochange=8fc46323cee61bddc4c38701d6020379bba5774a
Blocks: 1240594
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → General
Ever confirmed: true
Keywords: regression
Hardware: x86_64 → All
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8740404 [details]
MozReview Request: Bug 1263174 - fix hostname insertion in SSL error pages, r?past

https://reviewboard.mozilla.org/r/45741/#review42335
Attachment #8740404 - Flags: review?(past) → review+
https://hg.mozilla.org/mozilla-central/rev/322af6a2c02a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.