Open Bug 1263213 Opened 4 years ago Updated 1 year ago

Intermittent docshell/test/navigation/test_reserved.html | Should not be able to navigate off-domain parent by {calling window.open|submitting form|targeted hyperlink|setting location}

Categories

(Core :: Security, defect, P5)

defect

Tracking

()

Tracking Status
e10s + ---
firefox47 --- unaffected
firefox48 --- disabled
firefox49 --- disabled

People

(Reporter: aryx, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [test disabled on debug e10s])

https://treeherder.mozilla.org/logviewer.html#?job_id=25423342&repo=mozilla-inbound

16:46:14     INFO -  115 INFO TEST-PASS | docshell/test/navigation/test_reserved.html | Should be able to navigate off-domain top by setting location.
16:46:14     INFO -  116 INFO TEST-PASS | docshell/test/navigation/test_reserved.html | Should be able to navigate off-domain top by calling window.open.
16:46:14     INFO -  117 INFO TEST-PASS | docshell/test/navigation/test_reserved.html | Should be able to navigate off-domain top by submitting form.
16:46:14     INFO -  118 INFO TEST-PASS | docshell/test/navigation/test_reserved.html | Should be able to navigate off-domain top by targeted hyperlink.
16:46:14     INFO -  119 INFO TEST-PASS | docshell/test/navigation/test_reserved.html | Should not be able to navigate off-domain parent by setting location.
16:46:14     INFO -  120 INFO TEST-UNEXPECTED-FAIL | docshell/test/navigation/test_reserved.html | Should not be able to navigate off-domain parent by calling window.open.
16:46:14     INFO -      isAccessible@docshell/test/navigation/NavigationUtils.js:83:5
16:46:14     INFO -      testParent/</<@docshell/test/navigation/test_reserved.html:62:7
16:46:14     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:622:12
16:46:14     INFO -      frameFinished@docshell/test/navigation/NavigationUtils.js:161:7
16:46:14     INFO -      searchForFinishedFrames@docshell/test/navigation/NavigationUtils.js:193:9
16:46:14     INFO -      xpcEnumerateContentWindows@docshell/test/navigation/NavigationUtils.js:132:5
16:46:14     INFO -      poll@docshell/test/navigation/NavigationUtils.js:204:7
16:46:14     INFO -      setInterval handler*xpcWaitForFinishedFrames@docshell/test/navigation/NavigationUtils.js:211:27
16:46:14     INFO -      testParent/<@docshell/test/navigation/test_reserved.html:61:5
16:46:14     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:622:12
16:46:14     INFO -      frameFinished@docshell/test/navigation/NavigationUtils.js:161:7
16:46:14     INFO -      searchForFinishedFrames@docshell/test/navigation/NavigationUtils.js:193:9
16:46:14     INFO -      xpcEnumerateContentWindows@docshell/test/navigation/NavigationUtils.js:132:5
16:46:14     INFO -      poll@docshell/test/navigation/NavigationUtils.js:204:7
16:46:14     INFO -      setInterval handler*xpcWaitForFinishedFrames@docshell/test/navigation/NavigationUtils.js:211:27
16:46:14     INFO -      testParent@docshell/test/navigation/test_reserved.html:55:3
16:46:14     INFO -      testTop/</</</<@docshell/test/navigation/test_reserved.html:45:11
16:46:14     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:622:12
16:46:14     INFO -      frameFinished@docshell/test/navigation/NavigationUtils.js:161:7
16:46:14     INFO -      searchForFinishedFrames@docshell/test/navigation/NavigationUtils.js:193:9
16:46:14     INFO -      xpcEnumerateContentWindows@docshell/test/navigation/NavigationUtils.js:132:5
16:46:14     INFO -      poll@docshell/test/navigation/NavigationUtils.js:204:7
16:46:14     INFO -      setInterval handler*xpcWaitForFinishedFrames@docshell/test/navigation/NavigationUtils.js:211:27
16:46:14     INFO -      testTop/</</<@docshell/test/navigation/test_reserved.html:40:9
16:46:14     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:622:12
16:46:14     INFO -      frameFinished@docshell/test/navigation/NavigationUtils.js:161:7
16:46:14     INFO -      searchForFinishedFrames@docshell/test/navigation/NavigationUtils.js:193:9
16:46:14     INFO -      xpcEnumerateContentWindows@docshell/test/navigation/NavigationUtils.js:132:5
16:46:14     INFO -      poll@docshell/test/navigation/NavigationUtils.js:204:7
16:46:14     INFO -      setInterval handler*xpcWaitForFinishedFrames@docshell/test/navigation/NavigationUtils.js:211:27
16:46:14     INFO -      testTop/</<@docshell/test/navigation/test_reserved.html:33:7
16:46:14     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:622:12
16:46:14     INFO -      frameFinished@docshell/test/navigation/NavigationUtils.js:161:7
16:46:14     INFO -      searchForFinishedFrames@docshell/test/navigation/NavigationUtils.js:193:9
16:46:14     INFO -      xpcEnumerateContentWindows@docshell/test/navigation/NavigationUtils.js:132:5
16:46:14     INFO -      poll@docshell/test/navigation/NavigationUtils.js:204:7
16:46:14     INFO -      setInterval handler*xpcWaitForFinishedFrames@docshell/test/navigation/NavigationUtils.js:211:27
16:46:14     INFO -      testTop/<@docshell/test/navigation/test_reserved.html:26:5
16:46:14     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:622:12
16:46:14     INFO -      frameFinished@docshell/test/navigation/NavigationUtils.js:161:7
16:46:14     INFO -      searchForFinishedFrames@docshell/test/navigation/NavigationUtils.js:193:9
16:46:14     INFO -      xpcEnumerateContentWindows@docshell/test/navigation/NavigationUtils.js:132:5
16:46:14     INFO -      poll@docshell/test/navigation/NavigationUtils.js:204:7
16:46:14     INFO -      setInterval handler*xpcWaitForFinishedFrames@docshell/test/navigation/NavigationUtils.js:211:27
16:46:14     INFO -      testTop@docshell/test/navigation/test_reserved.html:19:3
16:46:14     INFO -      window.onload@docshell/test/navigation/test_reserved.html:86:3
16:46:14     INFO -      EventHandlerNonNull*@docshell/test/navigation/test_reserved.html:85:1
This test has gotten very flaky recently. Any ideas what might be going on, Boris?
Blocks: e10s-tests
tracking-e10s: --- → ?
Flags: needinfo?(bzbarsky)
See Also: → 1067559
Summary: Intermittent docshell/test/navigation/test_reserved.html | Should not be able to navigate off-domain parent by calling window.open. → Intermittent docshell/test/navigation/test_reserved.html | Should not be able to navigate off-domain parent by {calling window.open|submitting form|targeted hyperlink}
Not offhand, but... is it only flaky in e10s, or non-e10s too?
Flags: needinfo?(bzbarsky)
All e10s from the looks of it.
It's theoretically possible that e10s breaks (possibly randomly) the window enumerator hackery in xpcEnumerateContentWindows as used by xpcWaitForFinishedFrames in docshell/test/navigation/NavigationUtils.js...
this is now more permanent it seems :(
boris can you take a look at this again since this is very frequent now, thanks!
Flags: needinfo?(bzbarsky)
I can try, but I'm not sure when I'll have time to do it, to be honest.  It's unlikely to be this coming week; I already have way too much other stuff on my plate.

Is this failing reliably enough that we can try bisecting on try to find out what commit introduced the problem?
Flags: needinfo?(cbook)
i would say its frequent but not perma failure so it can wait till you have time boris
Flags: needinfo?(cbook)
Flags: needinfo?(bzbarsky) → needinfo?(ryanvm)
Keywords: leave-open
Whiteboard: [test disabled on e10s]
Whiteboard: [test disabled on e10s] → [test disabled on debug e10s]
Intermittent e10s test failure
Priority: -- → P5
Summary: Intermittent docshell/test/navigation/test_reserved.html | Should not be able to navigate off-domain parent by {calling window.open|submitting form|targeted hyperlink} → Intermittent docshell/test/navigation/test_reserved.html | Should not be able to navigate off-domain parent by {calling window.open|submitting form|targeted hyperlink|setting location}
Duplicate of this bug: 1067559
The leave-open keyword is there and there is no activity for 6 months.
:wleung, maybe it's time to close this bug?
Flags: needinfo?(wleung)

Hi Christoph, please comment.

Flags: needinfo?(wleung) → needinfo?(ckerschb)

(In reply to Wennie from comment #49)

Hi Christoph, please comment.

Well the test got disabled for debug builds, hence I guess we can close this bug. In a separate effort we should try to re-enable tests that got disabled over the years. But the intermittent issue is gone here, so I would be fine closing this bug. No need for leaving it open longer.

Flags: needinfo?(ckerschb)
You need to log in before you can comment on or make changes to this bug.