(From Bug 1259169 comment #0) > In bug 1245184 we changed nsICookieManager::remove(). But that broke many > addons. We want to support the old prototype of ::remove() for 1 or 2 > releases to give times to addon developers to update their code.
As far as I can see only the two attributes switched places. Has been backed out of m-c for now so I didn't test it. Setting review when it's ready to be put in.
Assignee: nobody → frgrahl
Comment on attachment 8739580 [details] [diff] [review] 1263252-cookie-remove-options.patch Underlying Bug 1259169 is now on m-i and should land today or tomorrow
Comment on attachment 8739580 [details] [diff] [review] 1263252-cookie-remove-options.patch For consistency you should fix order in the Cookie constructor in cookieViewer.js, and _makeCookieObject: in dataman.js
V2 Change remove calls and reorder constructors to match key fields.
Comment on attachment 8740508 [details] [diff] [review] 1263252-cookie-remove-options-V2.patch nice. r=me
Attachment #8740508 - Flags: review?(philip.chee) → review+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.45
Comment on attachment 8740508 [details] [diff] [review] 1263252-cookie-remove-options-V2.patch [Approval Request Comment] Regression caused by (bug #): 1259169 - nsICookieManager::remove() should be back-compatible for 1 or 2 releases User impact if declined: Cookie Viewer and Data Manager would break. Cookie removal would fail or cause unexpected results. Testing completed (on m-c, etc.): c-c Risk to taking this patch (and alternatives if risky): none. Functionality is broken without the patch. String changes made by this patch: none.
Attachment #8740508 - Flags: approval-comm-aurora?
Bug 1259169 has just been put into m-a too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8740508 [details] [diff] [review] 1263252-cookie-remove-options-V2.patch a=me for comm-aurora.
Attachment #8740508 - Flags: approval-comm-aurora? → approval-comm-aurora+
Whiteboard: [checkin-needed comm-aurora Comment 9]
You need to log in before you can comment on or make changes to this bug.