Closed
Bug 1263252
Opened 8 years ago
Closed 8 years ago
Update SeaMonkey cookie code for mozilla-central Bug 1259169 [nsICookieManager::remove() should be back-compatible]
Categories
(SeaMonkey :: Passwords & Permissions, defect)
Tracking
(seamonkey2.44+ fixed, seamonkey2.46+ fixed)
RESOLVED
FIXED
seamonkey2.45
People
(Reporter: philip.chee, Assigned: frg)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.58 KB,
patch
|
philip.chee
:
review+
philip.chee
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
(From Bug 1259169 comment #0) > In bug 1245184 we changed nsICookieManager::remove(). But that broke many > addons. We want to support the old prototype of ::remove() for 1 or 2 > releases to give times to addon developers to update their code.
|
Reporter | |
Updated•8 years ago
|
status-seamonkey2.44:
--- → affected
status-seamonkey2.46:
--- → affected
|
|
Assignee | |
Comment 1•8 years ago
|
||
As far as I can see only the two attributes switched places. Has been backed out of m-c for now so I didn't test it. Setting review when it's ready to be put in.
Assignee: nobody → frgrahl
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8739580 [details] [diff] [review] 1263252-cookie-remove-options.patch Underlying Bug 1259169 is now on m-i and should land today or tomorrow
Attachment #8739580 -
Flags: review?(philip.chee)
|
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8739580 [details] [diff] [review] 1263252-cookie-remove-options.patch For consistency you should fix order in the Cookie constructor in cookieViewer.js, and _makeCookieObject: in dataman.js
|
|
Reporter | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•8 years ago
|
||
V2 Change remove calls and reorder constructors to match key fields.
Attachment #8739580 -
Attachment is obsolete: true
Attachment #8739580 -
Flags: review?(philip.chee)
Attachment #8740508 -
Flags: review?(philip.chee)
|
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8740508 [details] [diff] [review] 1263252-cookie-remove-options-V2.patch nice. r=me
Attachment #8740508 -
Flags: review?(philip.chee) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4560655b6160b9e2ceaff774b66092bf7a556a7a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.45
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8740508 [details] [diff] [review] 1263252-cookie-remove-options-V2.patch [Approval Request Comment] Regression caused by (bug #): 1259169 - nsICookieManager::remove() should be back-compatible for 1 or 2 releases User impact if declined: Cookie Viewer and Data Manager would break. Cookie removal would fail or cause unexpected results. Testing completed (on m-c, etc.): c-c Risk to taking this patch (and alternatives if risky): none. Functionality is broken without the patch. String changes made by this patch: none.
Attachment #8740508 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Comment 8•8 years ago
|
||
Bug 1259169 has just been put into m-a too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 9•8 years ago
|
||
Comment on attachment 8740508 [details] [diff] [review] 1263252-cookie-remove-options-V2.patch a=me for comm-aurora.
Attachment #8740508 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Reporter | |
Updated•8 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin-needed comm-aurora Comment 9]
|
|
Reporter | |
Comment 10•8 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/dd86a1b531ee http://hg.mozilla.org/releases/comm-aurora/rev/7d7b42759895
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin-needed comm-aurora Comment 9]
|
|
Reporter | |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•