1263279 - add balrog rules for TB 45.0ESR builds in release configs

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Kim Moir [:kmoir] ET]

message to tb-drivers

The release update job is failing for 45.0 i because we don't have balrog rules in place for 45.0esr.  In order to set these up I need to know:

Do you intend to publish updates to 38 users yet? If so, we will need to create rules matching version>45.0,  otherwise we can reuse the existing ones from 38.

response

We follow the ESR schedule and release numbering.
So we expect to continue publishing through at least 38.8.0.


--
I'll attach patches to update the rules in our release configs.  I've already added the rules to balrog.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1263279.patch

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug1263279-2.patch

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8739572 [details] [diff] [review]
bug1263279-2.patch

Review of attachment 8739572 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine now. May want to add alias' for those rules in the future.

Comment 4

[Kim Moir [:kmoir] ET]

Comment on attachment 8739572 [details] [diff] [review]
bug1263279-2.patch

and tagged, rerunning the updates builder

Comment 5

[Kim Moir [:kmoir] ET]

Attachment: bug1263279-3.patch

Comment 6

[Kim Moir [:kmoir] ET]

To fix landed this patch in bb-configs
transplanted commit to production
retagged with release tags

then backed out patcher configs in tools, reran release_updates job
http://buildbot-master74.bb.releng.usw2.mozilla.com:8001/builders/release-comm-esr45-thunderbird_release_updates/builds/4

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Kim Moir [:kmoir] from comment #0)
> message to tb-drivers
> 
> The release update job is failing for 45.0 i because we don't have balrog
> rules in place for 45.0esr.  In order to set these up I need to know:
> 
> Do you intend to publish updates to 38 users yet? If so, we will need to
> create rules matching version>45.0,  otherwise we can reuse the existing
> ones from 38.
> 
> response
> 
> We follow the ESR schedule and release numbering.
> So we expect to continue publishing through at least 38.8.0.

I goofed here, so to clarify this in context of recent emails sent to thunderbird-drivers about not being able to update from version 38 ...

I failed to state that our plans are multi-scenario - that we need to update "some" 38.x users to 45.0, but perhaps keep most users on 38 for a long period of time. 

So with an initial small group of version 45.0 users we would assess whether version 45.0 is solid enough to update all 38 users to update 45.0.  If it is not good enough then we would ask balrog be set to (its current state of) version 38 users updating to 38 and 45 users updating to 45. In other words, only the ones on 45.0 would be allowed to update to 45.1.0, and the remaning 38.x users would update to 38.8.0.

We would then again assess whether version 45.1.0 is ready for the masses to update 38 to 45.1.0, or wait for (a better) 45.2.

Comment 8

[Kim Moir [:kmoir] ET]

rail: Is the correct approach to change rule 332 in balrog so that the 45.0 build has its version restriction removed for users (Version: >45.0) and it the rate changed to a low percentage? This will allow users with 38.0 to update but at a slow rate? Then we could change this back at the discretion of the TB team?

Comment 9

[Rail Aliiev [:rail]]

Sounds correct to me. I'd also change the >45.0 cdntest rule before changing this one to verify the behavior.

Comment 10

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/4a4c57503630

Comment 11

[Kim Moir [:kmoir] ET]

Okay, I've changed the cdntest rule (id 334) to remove the (Version: >45.0) restriction and set the rate to 10