Closed Bug 1263311 Opened 5 years ago Closed 5 years ago

Rework nsICancelableRunnable

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: khuey, Assigned: khuey)

Details

Attachments

(3 files)

An act in three parts.
Attachment #8739599 - Flags: review?(nfroyd)
Comment on attachment 8739599 [details] [diff] [review]
Part 1: Change the interface

Review of attachment 8739599 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.
Attachment #8739599 - Flags: review?(nfroyd) → review+
Attachment #8739600 - Flags: review?(nfroyd) → review+
Comment on attachment 8739601 [details] [diff] [review]
Part 3: s/nsCancelableRunnable/CancelableRunnable/g

Review of attachment 8739601 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer this be s/nsCancelableRunnable/mozilla::CancelableRunnable/, but that's probably a bit of a pain.  File a followup bug?
Attachment #8739601 - Flags: review?(nfroyd) → review+
Flags: needinfo?(khuey)
You need to log in before you can comment on or make changes to this bug.