1263311 - Rework nsICancelableRunnable

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Part 1: Change the interface

An act in three parts.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Part 2: Remove a non-existent CancelableRunnable

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Part 3: s/nsCancelableRunnable/CancelableRunnable/g

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8739599 [details] [diff] [review]
Part 1: Change the interface

Review of attachment 8739599 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8739601 [details] [diff] [review]
Part 3: s/nsCancelableRunnable/CancelableRunnable/g

Review of attachment 8739601 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer this be s/nsCancelableRunnable/mozilla::CancelableRunnable/, but that's probably a bit of a pain.  File a followup bug?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18132498bc40
https://hg.mozilla.org/integration/mozilla-inbound/rev/60b1be29446c
https://hg.mozilla.org/integration/mozilla-inbound/rev/0434a548e1fe

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/61ca2f5fd696 for Windows build failures like https://treeherder.mozilla.org/logviewer.html#?job_id=25544677&repo=mozilla-inbound

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81d0c00bb82f
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ca7effcd9ab
https://hg.mozilla.org/integration/mozilla-inbound/rev/9639832c996c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81d0c00bb82f
https://hg.mozilla.org/mozilla-central/rev/6ca7effcd9ab
https://hg.mozilla.org/mozilla-central/rev/9639832c996c