1263324 - Add a test case to test context id for devtools storage inspector

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Tim Huang[:timhuang]]

We had made storage inspector contextual id aware in Bug 1237915. Now, we need a test case to test that the contextual id works correctly in the storage inspector.

Comment 1

[Ethan Tseng [:ethan]]

*** Explanation for why this bug depends on bug 1195930 (Use origin in QuotaManager) ***

Devtools storage inspector indirectly uses QuotaManager functions through indexedDB.
devtools/server/actors/storage.js calls indexedDB functions, which end up with calling QuotaManager::GetStorageId() when indexedDB opens a database.

If QuotaManager is not OriginAttributes-aware, we cannot add test cases for the purpose of this bug,
which is aimed at verifying the correctness of using userContextId in devtools storage inspector.

p.s. Test case shall be added in: devtools/client/storage/test

Comment 2

[Ethan Tseng [:ethan]]

It would be nice if we can have this bug resolved in FF 50, but we can wait until 51.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1263324 - Part 1: Fixing the cache storage inspector to obey originAttributes and indexedDB storage inspector to use correct database file name with originAttributes.

Review commit: https://reviewboard.mozilla.org/r/109458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109458/

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1263324 - Part 2: Add test cases to test context id for devtools storage inspector.

Review commit: https://reviewboard.mozilla.org/r/109460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109460/

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8833225 [details]
Bug 1263324 - Part 1: Fixing the cache storage inspector to obey originAttributes and indexedDB storage inspector to use correct database file name with originAttributes.

https://reviewboard.mozilla.org/r/109458/#review110616

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8833226 [details]
Bug 1263324 - Part 2: Add test cases to test context id for devtools storage inspector.

https://reviewboard.mozilla.org/r/109460/#review110624

Looks fine but storage inspector tests used to time out regularly we need to make sure multiple try runs are successful before we land this:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7abcf2784256

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Actually, let's run the tests 5 times: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f5a6f5b60e2

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Okay, you just need to make 3 linting changes before we can land this:

- TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/client/storage/test/browser_storage_basic_usercontextid.js:84:1 | Line 84 exceeds the maximum line length of 90. (max-len)

- TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/client/storage/test/browser_storage_basic_usercontextid.js:176:1 | Line 176 exceeds the maximum line length of 90. (max-len)

- TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/client/storage/test/browser_storage_delete_usercontextid.js:174:4 | Newline required at end of file but not found. (eol-last)

Comment 9

[Tim Huang[:timhuang]]

Thanks, mratcliffe. I will update these lines.

Comment 10

[Tim Huang[:timhuang]]

Comment on attachment 8833225 [details]
Bug 1263324 - Part 1: Fixing the cache storage inspector to obey originAttributes and indexedDB storage inspector to use correct database file name with originAttributes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109458/diff/1-2/

Comment 11

[Tim Huang[:timhuang]]

Comment on attachment 8833226 [details]
Bug 1263324 - Part 2: Add test cases to test context id for devtools storage inspector.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109460/diff/1-2/

Comment 12

[Tim Huang[:timhuang]]

Try looks good.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f25a442f75b
Part 1: Fixing the cache storage inspector to obey originAttributes and indexedDB storage inspector to use correct database file name with originAttributes. r=miker
https://hg.mozilla.org/integration/autoland/rev/2c9ed54ef2e1
Part 2: Add test cases to test context id for devtools storage inspector. r=miker

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f25a442f75b
https://hg.mozilla.org/mozilla-central/rev/2c9ed54ef2e1