Updating the display port margins should schedule a paint if the critical displayport changes

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

48 Branch
mozilla48
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

I've noticed a lot of running into low-res content on Fennec, sometimes even getting that in a perma-low-res state. With the minimap it's clear that the critical displayport is not moving with the viewport properly, and I suspect it's because I'm at the edge of the content where the full displayport isn't moving. The code in nsLayoutUtils::SetDisplayPortMarginsForElement should check for changes in the critical dp as well as the regular dp when deciding whether or not to schedule a paint.
Comment on attachment 8742505 [details]
MozReview Request: Bug 1263347 - When checking if displayport changes should schedule a paint, make sure to use the proper displayport. r?mstange

https://reviewboard.mozilla.org/r/47241/#review43929
Attachment #8742505 - Flags: review?(mstange) → review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/552d5832785a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.