1263404 - Single-element JSON arrays cannot be expanded

Status: VERIFIED FIXED

(DevTools :: JSON Viewer, defect, P1)

Description

[Dan Callahan [:callahad]]

STR:

1. Visit https://accounts.google.com/.well-known/openid-configuration
2. Attempt to expand the `subject_types_supported` key

What should happen:

- I see ["public"]

What actually happens:

- I see nothing

Comment 1

[Phil [:philr]]

Can't reproduce it 
FF Dev 47.0a2 (2016-04-10)

Comment 2

[Dan Callahan [:callahad]]

Ah, yep, only seeing this on Nightly.

Comment 3

[kong.shijun]

I was hit by this bug today. Waste half hour debugging my server side code...

48.0a2 (2016-05-03

Comment 4

[Dan Callahan [:callahad]]

Attachment: Screencast demonstrating bug

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Honza, could you take a look at this?

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1263404.patch

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

[Tracking Requested - why for this release]: Let's be sure to uplift to 48.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0c860fab34ea

Comment 9

[Carsten Book [:Tomcat]]

backed this out in https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=df57a1d196dc seems one of this 2 changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=9144862&repo=fx-team#L0-L8834

can you take a look, thanks!

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1263404.patch

(In reply to Carsten Book [:Tomcat] from comment #9)
> backed this out in
> https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=df57a1d196dc
> seems one of this 2 changes caused
> https://treeherder.mozilla.org/logviewer.html#?job_id=9144862&repo=fx-
> team#L0-L8834
> 
> can you take a look, thanks!
Ah yes, sorry, the failure totally make sense.

New patch attached.

- The original fix stays the same
- JSON view test adopted
- One React warning fixed (worthless binding)

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72170dd3faea

Let's see how that try goes!

Honza

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Try looks good, let's try to ship this.

Honza

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2451d15ff234

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2451d15ff234

Comment 15

[Marcia Knous [:marcia]]

Tracking for 48 - do we want to uplift this to 48?

Comment 16

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8748618 [details] [diff] [review]
bug1263404.patch

Approval Request Comment
[Feature/regressing bug #]: JSON Viewer
[User impact if declined]: See https://bug1263404.bmoattachments.org/attachment.cgi?id=8748271
[Describe test coverage new/current, TreeHerder]: in Nightly
[Risks and why]: Low
[String/UUID change made/needed]: n/a

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8748618 [details] [diff] [review]
bug1263404.patch

Improve a new feature, taking it.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/30ef13031f3b

Comment 19

[Mohammad Maruf Rahman]

I have reproduced this bug with nightly 48.0a1 (2016-04-09) on Windows 7, 64 Bit!

This bug's fix is verified on latest Developer Edition,latest Beta.


Build ID       20160708004052
User Agent     Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0


Build ID       20160714050942
User Agent     Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0

Comment 20

[Bogdan Maris, Desktop QA]

Thanks for testing Rahman!
I also verified this using latest DevEdition 49.0a2 on Mac OS X 10.10.5