Closed Bug 1263404 Opened 4 years ago Closed 4 years ago

Single-element JSON arrays cannot be expanded

Categories

(DevTools :: JSON Viewer, defect, P1)

48 Branch
defect

Tracking

(firefox47 unaffected, firefox48+ fixed, firefox49 verified)

VERIFIED FIXED
Firefox 49
Tracking Status
firefox47 --- unaffected
firefox48 + fixed
firefox49 --- verified

People

(Reporter: callahad, Assigned: Honza)

References

Details

(Keywords: DevAdvocacy)

Attachments

(2 files, 1 obsolete file)

STR:

1. Visit https://accounts.google.com/.well-known/openid-configuration
2. Attempt to expand the `subject_types_supported` key

What should happen:

- I see ["public"]

What actually happens:

- I see nothing
Can't reproduce it 
FF Dev 47.0a2 (2016-04-10)
Ah, yep, only seeing this on Nightly.
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → 48 Branch
I was hit by this bug today. Waste half hour debugging my server side code...

48.0a2 (2016-05-03
Honza, could you take a look at this?
Flags: needinfo?(odvarko)
Priority: -- → P1
Assignee: nobody → odvarko
Flags: needinfo?(odvarko)
Attached patch bug1263404.patch (obsolete) — Splinter Review
Attachment #8748288 - Flags: review?(jryans)
[Tracking Requested - why for this release]: Let's be sure to uplift to 48.
backed this out in https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=df57a1d196dc seems one of this 2 changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=9144862&repo=fx-team#L0-L8834

can you take a look, thanks!
Flags: needinfo?(odvarko)
Attached patch bug1263404.patchSplinter Review
(In reply to Carsten Book [:Tomcat] from comment #9)
> backed this out in
> https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=df57a1d196dc
> seems one of this 2 changes caused
> https://treeherder.mozilla.org/logviewer.html#?job_id=9144862&repo=fx-
> team#L0-L8834
> 
> can you take a look, thanks!
Ah yes, sorry, the failure totally make sense.

New patch attached.

- The original fix stays the same
- JSON view test adopted
- One React warning fixed (worthless binding)

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72170dd3faea

Let's see how that try goes!

Honza
Attachment #8748288 - Attachment is obsolete: true
Flags: needinfo?(odvarko)
Attachment #8748618 - Flags: review?(jryans)
Try looks good, let's try to ship this.

Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2451d15ff234
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Tracking for 48 - do we want to uplift this to 48?
Flags: needinfo?(odvarko)
Comment on attachment 8748618 [details] [diff] [review]
bug1263404.patch

Approval Request Comment
[Feature/regressing bug #]: JSON Viewer
[User impact if declined]: See https://bug1263404.bmoattachments.org/attachment.cgi?id=8748271
[Describe test coverage new/current, TreeHerder]: in Nightly
[Risks and why]: Low
[String/UUID change made/needed]: n/a
Flags: needinfo?(odvarko)
Attachment #8748618 - Flags: approval-mozilla-aurora?
Comment on attachment 8748618 [details] [diff] [review]
bug1263404.patch

Improve a new feature, taking it.
Attachment #8748618 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this bug with nightly 48.0a1 (2016-04-09) on Windows 7, 64 Bit!

This bug's fix is verified on latest Developer Edition,latest Beta.


Build ID       20160708004052
User Agent     Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0


Build ID       20160714050942
User Agent     Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0
Thanks for testing Rahman!
I also verified this using latest DevEdition 49.0a2 on Mac OS X 10.10.5
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.