126344 - nsDownloader::OnStartRequest() should handle failure of SetCacheAsFile()

Status: RESOLVED DUPLICATE of bug 209560

(Core :: Networking, defect)

Description

[gordon]

nsDownloader::OnStartRequest() will simply fail if SetCacheAsFile() fails.  It
should probably try streaming the data to a temp file...or something.

Comment 1

[gordon]

This may have an impact on signed javascript.

Comment 2

[benc]

+helpwanted: eng requests go straight to eng triage.

Comment 3

[Doug Turner (:dougt)]

neeti can you look at this.

Comment 4

[neeti]

mitch, darin: what is the impact here if SetCacheAsFile() fails in 
nsDownloader::OnStartRequest() ?

Comment 5

[Darin Fisher]

neeti: nsDownloader is used to download remote jar files (e.g., URLs like:
jar:http://...).  if nsDownloader fails, then loading of such a jar file will
fail.  NOTE: the jar protocol circumvents nsDownloader if the inner URL can be
mapped to a nsIFile (which is the case for resource:// and file://).

this bug may prevent jar:https:// URLs from loading since https:// URLs are not
cached on disk.  or, does SetCacheAsFile(PR_TRUE) trump that??

Comment 6

[neeti]

darin, mitch: Do you know of any urls I could use to test the download code for
jar:https:// URLs ?

thanks,
Neeti

Comment 7

[Darin Fisher]

neeti: no, i don't know of any sample URLs.  you might also want to check out
bug 172279, which is somewhat related.

Comment 8

[Doug Turner (:dougt)]

neeti no longer works on mozilla stuff.

Comment 9

[Mitchell Stoltz (not reading bugmail)]

jar:http://warp.mcom.com/u/mstoltz/tests/basic.jar!/basic.html

...in case anyone wants a jar URL testcase

Comment 10

[Darin Fisher]

I fixed this in bug 209560.

Comment 11

[Darin Fisher]

*** This bug has been marked as a duplicate of 209560 ***