1263460 - Fix UI on Long press of empty Yahoo search field

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Mark Capella [:capella]]

This has been lurking for a while in TextSelection, and it's time to fix.

Inherited from SelectionHandler, the ActionBarHandler._getSelectedText() method does a string trim before returning it's result, producing inconsistencies in UI as evidenced here [0]. The solution looks as here [1].

I'm not aware of any consumers that require the result be trimmed, internally, or externally (by the "TextSelection:Get" message of FindInPageBar for example). If identified later, those should be fixed instead.

[0] https://www.dropbox.com/s/z5myowlfg13z7ud/yahooBug_before.png?dl=0
[1] https://www.dropbox.com/s/v91tnvhbl8hq7u3/yahooBug_after.png?dl=0

Comment 1

[Mark Capella [:capella]]

Attachment: MozReview Request: Bug 1263460 - Fix UI on Long press of empty Yahoo search field, r=sebastian

Review commit: https://reviewboard.mozilla.org/r/45373/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45373/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8739790 [details]
MozReview Request: Bug 1263460 - Fix UI on Long press of empty Yahoo search field, r=sebastian

https://reviewboard.mozilla.org/r/45373/#review42309

Comment 3

[Mark Capella [:capella]]

Looks good on TRY
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54939b0fce0ccae57e36f180fbc817ae72d1ebe2

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fc46dfa8cfc9

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fc46dfa8cfc9