Closed Bug 1263460 Opened 4 years ago Closed 4 years ago

Fix UI on Long press of empty Yahoo search field

Categories

(Firefox for Android :: Text Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: capella, Assigned: capella)

Details

Attachments

(1 file)

This has been lurking for a while in TextSelection, and it's time to fix.

Inherited from SelectionHandler, the ActionBarHandler._getSelectedText() method does a string trim before returning it's result, producing inconsistencies in UI as evidenced here [0]. The solution looks as here [1].

I'm not aware of any consumers that require the result be trimmed, internally, or externally (by the "TextSelection:Get" message of FindInPageBar for example). If identified later, those should be fixed instead.

[0] https://www.dropbox.com/s/z5myowlfg13z7ud/yahooBug_before.png?dl=0
[1] https://www.dropbox.com/s/v91tnvhbl8hq7u3/yahooBug_after.png?dl=0
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Comment on attachment 8739790 [details]
MozReview Request: Bug 1263460 - Fix UI on Long press of empty Yahoo search field, r=sebastian

https://reviewboard.mozilla.org/r/45373/#review42309
Attachment #8739790 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/mozilla-central/rev/fc46dfa8cfc9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.