Fix UI on Long press of empty Yahoo search field

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
Text Selection
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: capella, Assigned: capella)

Tracking

unspecified
Firefox 48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This has been lurking for a while in TextSelection, and it's time to fix.

Inherited from SelectionHandler, the ActionBarHandler._getSelectedText() method does a string trim before returning it's result, producing inconsistencies in UI as evidenced here [0]. The solution looks as here [1].

I'm not aware of any consumers that require the result be trimmed, internally, or externally (by the "TextSelection:Get" message of FindInPageBar for example). If identified later, those should be fixed instead.

[0] https://www.dropbox.com/s/z5myowlfg13z7ud/yahooBug_before.png?dl=0
[1] https://www.dropbox.com/s/v91tnvhbl8hq7u3/yahooBug_after.png?dl=0
(Assignee)

Comment 1

2 years ago
Created attachment 8739790 [details]
MozReview Request: Bug 1263460 - Fix UI on Long press of empty Yahoo search field, r=sebastian

Review commit: https://reviewboard.mozilla.org/r/45373/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45373/
Attachment #8739790 - Flags: review?(s.kaspari)
(Assignee)

Updated

2 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Comment on attachment 8739790 [details]
MozReview Request: Bug 1263460 - Fix UI on Long press of empty Yahoo search field, r=sebastian

https://reviewboard.mozilla.org/r/45373/#review42309
Attachment #8739790 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 3

2 years ago
Looks good on TRY
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54939b0fce0ccae57e36f180fbc817ae72d1ebe2

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/fc46dfa8cfc9

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fc46dfa8cfc9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.