1263491 - Make SetSpecifiedTiming (and possibly Play/PauseFromStyle) do observer notification

Status: RESOLVED INVALID

(Core :: DOM: Animation, defect)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Bug 1260655 will make SetFrames do observer notification (since this needs to happen when we expose SetFrames to javascript anyway). That means we no longer need to check for changes to the frames in UpdateOldAnimationPropertiesWithNew (in nsAnimationManager.cpp). We should do the same thing for SetSpecifiedTimingProperties to make it more encapsulated and reusable.

We should possibly also do the same for Play/PauseFromStyle although I haven't really looked into that yet. Doing that would mean we can get rid of the animationChanged local variable altogether.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

(In reply to Brian Birtles (:birtles) from comment #0)
> Bug 1260655 will make SetFrames do observer notification (since this needs
> to happen when we expose SetFrames to javascript anyway). That means we no
> longer need to check for changes to the frames in
> UpdateOldAnimationPropertiesWithNew (in nsAnimationManager.cpp). We should
> do the same thing for SetSpecifiedTimingProperties to make it more
> encapsulated and reusable.

Another thing I notice is that we can call RequestRestyle(Layer) in the same condition.  I mean that if we need to call nsNodeUtils::AnimationChanged(), it's the time to call RequestRestyle(Layer).  At least in KeyframeEffect and KeyframeEffectReadOnly, it seems be right.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

It looks to me like we're doing this now:

• https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/dom/animation/AnimationEffect.cpp#81-83

Animation::PlayNoUpdate and Animation::Pause also appear to be doing observer notification.