1263506 - GeckoMediaPlugins gtests fail on Windows

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The GeckoMediaPlugins gtests fail on Windows, with the following warnings:

Running GTest tests...
[6296] WARNING: NS_ENSURE_TRUE(greBinD) failed: file c:\Users\cpearce\src\mozilla\purple\objdir\dist\include\testing/TestHarness.h, line 255
[6296] WARNING: NS_ENSURE_TRUE(greD) failed: file c:\Users\cpearce\src\mozilla\purple\objdir\dist\include\testing/TestHarness.h, line 248
Note: Google Test filter = *GeckoMediaPlugins*
[==========] Running 22 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 22 tests from GeckoMediaPlugins
[ RUN      ] GeckoMediaPlugins.GMPTestCodec
[6296] WARNING: 'NS_FAILED(rv)', file c:/Users/cpearce/src/mozilla/purple/dom/media/gmp/GMPServiceParent.cpp, line 994
[6296] WARNING: 'NS_FAILED(rv)', file c:/Users/cpearce/src/mozilla/purple/dom/media/gmp/GMPServiceParent.cpp, line 994


The warning GMPServiceParent.cpp, line 994 is a NS_NewLocalFile failure, due to the MOZ_GMP_PATH environment variable which the GMP gtests rely on containing Unix dir separators. NS_NewLocalFile on Windows can only handle Windows dir separators. MOZ_GMP_PATH needs to be normalized to Windows dir separators on Windows.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Ensure MOZ_GMP_PATH in gtests always has native dir separators

Without this, the GeckoMediaPlugin gtests fail, as the GMP stack is unable to
load GMPs from disk.

MozReview-Commit-ID: GGXdm2L5IF9

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8d50064c15b51ccdeae349dca3b0a83e567487e
Bug 1263506 - Ensure MOZ_GMP_PATH in gtests always has native dir separators. r=glandium

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d8d50064c15b

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8739835 [details] [diff] [review]
Ensure MOZ_GMP_PATH in gtests always has native dir separators

Approval Request Comment
[Feature/regressing bug #]: GeckoMediaPlugins' gtests on Windows
[User impact if declined]:  Negligible user impact, but improved reliability of Gecko Media Plugins' gtests. Without this patch the GMP gtests don't work on my local Windows machine. Quite frankly, I don't know how gtests on Windows in our automation are working at all without this patch!
[Describe test coverage new/current, TreeHerder]: We have a number of gtests that I don't know how they're working without this change.
[Risks and why]: None; build/automation only change.
[String/UUID change made/needed]: None.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8739835 [details] [diff] [review]
Ensure MOZ_GMP_PATH in gtests always has native dir separators

NPOTB we ship, Aurora47+

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Ryan, Wes: Would you be able to address the concern (on whether gmp tests are running on windows at all) that CPearce has mentioned in comment 4? Is this something that is already known? Thanks!

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I see a number of "WARNING:"s in that section of the gtest log, but not those particular ones. Unsure what exactly that means.

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-aurora-win32-debug/1461075033/mozilla-aurora_win7-ix-debug_test-gtest-bm127-tests1-windows-build0.txt.gz

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/04ac010a94861369bc8d8a039ab7ddd0136127ad