Enable background-clip:text preference in non-release builds

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

({dev-doc-complete})

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Turning on background-clip-text  pref by default.
We probably need to ship this at the same time as layout.css.prefixes.webkit, since the reason it's important is that pages depend on -webkit-*-gradient() support matching -webkit-background-clip:text support.  So once we think this is ready (hopefully soon), perhaps this bug should be about switching this to be part of layout.css.prefixes.webkit instead of a separate pref.
Summary: Enable backgound-clip-text preference → Enable background-clip:text preference
Component: Layout → CSS Parsing and Computation
Version: unspecified → Trunk
(In reply to David Baron [:dbaron] ⌚️UTC-7 from comment #1)
> perhaps this bug
> should be about switching this to be part of layout.css.prefixes.webkit
> instead of a separate pref.

For the short term, I'd prefer to just take a one-liner patch that just flips the background-clip:text pref to true, so this can start getting Nightly testing (now that the implementation has landed).

I prefer that over merging the prefs, because:
 (1) it's easy
 (2) it gives us the ability to easily un-ship this feature on Nightly/Aurora if we discover problems with it (to return us to the current state of being)

Ultimately we may want to merge the prefs, but I'm also not too concerned about that, as long as we're cognizant of the fact that we mustn't un-ship this feature from release/beta without also un-shipping webkit prefix support [or we'd end up causing bugs like bug 1238527].
CJ, is there anything blocking us from flipping the background-clip:text pref, now that bug 759568 has landed?

(Would you be up for taking this and tweaking all.js to enable this feature?)
Flags: needinfo?(cku)
Assignee

Comment 4

3 years ago
Since I am fixing Bug 1261578 now, I found that patches in bug 759568 do not handle "text-overflow: ellipsis" correctly. But I do not think it is a blocker of turning on background-clip:text pref. Other then that.

How about just turning on this pref on nightly/ aurora(just like webkitprefix pref) right away so that people can feel and test on this feature? And sure, I am happy to do it.
Flags: needinfo?(cku) → needinfo?(dholbert)
Assignee

Comment 5

3 years ago
(In reply to C.J. Ku[:cjku] from comment #4)
> Since I am fixing Bug 1261578 now, I found that patches in bug 759568 do not
> handle "text-overflow: ellipsis" correctly. But I do not think it is a
> blocker of turning on background-clip:text pref. Other then that,
I do not see a reason, from my side, for not enabling it on nightly.
> 
> How about just turning on this pref on nightly/ aurora(just like
> webkitprefix pref) right away so that people can feel and test on this
> feature? And sure, I am happy to do it.
Comment on attachment 8741615 [details] [diff] [review]
Turn on background-clip:text pref on Nightly/Aurora

Review of attachment 8741615 [details] [diff] [review]:
-----------------------------------------------------------------

I'll proactively jump in and r+ this, assuming it doesn't break any tests.

> Bug 1263516 - turn on background-clip:text pref on Nightly and Aurora;

It's a bit confusing for a mozilla-central commit to say that it's doing something on Aurora. (That sounds like this is being backported or something.)

I think "in non-release builds" would be clearer than "on Nightly and Aurora".

Not a big deal though. r=me regardless
Attachment #8741615 - Flags: review+
Flags: needinfo?(dholbert)
Please update the title of this bug to reflect what it's actually doing (only enabling the pref in non-release builds), and file a followup bug on letting this pref ride the trains past aurora (similar to bug 1259345).

And please mark the bug w/ ellipsis as blocking that bug.
Assignee

Updated

3 years ago
Summary: Enable background-clip:text preference → Enable background-clip:text preference in non-release builds
Assignee

Updated

3 years ago
No longer blocks: 1259345
Assignee

Comment 11

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7922c7e1a69eb117431de3b2241a1ea1dc3fac08
Bug 1263516 - turn on background-clip:text pref in non-release builds; r=dholbert

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7922c7e1a69e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.