Closed Bug 1263609 Opened 7 years ago Closed 7 years ago

[SharedStubs] Port jsop_pow

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: h4writer, Assigned: h4writer)

References

Details

Attachments

(1 file, 1 obsolete file)

bugXXX-sharedstubs-pow
12.64 KB, patch
efaust
: review+
Details | Diff | Splinter Review 
Quite easy since pow is a binary arith. So it can reuse that. While busy, I also removed the special-casing of certain constants to be done in gvn. It fits better there!
Attached patch bugXXX-sharedstubs-pow (obsolete) — — Splinter Review 
Assignee: nobody → hv1989

        Attachment #8739967 -
        Flags: review?(efaustbmo)

    
  
Blocks: 1161516

    
    

    
  


  
forgot to qref

        Attachment #8739967 -
        Attachment is obsolete: true

        Attachment #8739967 -
        Flags: review?(efaustbmo)

        Attachment #8740055 -
        Flags: review?(efaustbmo)

    
    

    
  
Comment on attachment 8740055 [details] [diff] [review]
bugXXX-sharedstubs-pow

Review of attachment 8740055 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

        Attachment #8740055 -
        Flags: review?(efaustbmo) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/33ceb53fd609
https://hg.mozilla.org/mozilla-central/rev/d5a155608cc1
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox48:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

    
  
No longer depends on: 1293542

          You need to log in
          before you can comment on or make changes to this bug.