1263610 - Links in theme descriptions don't show up properly in an add-on description

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Mike Kaply [:mkaply]]

If you add a theme that has a proper link on AMO:

https://addons.mozilla.org/en-US/firefox/addon/dewy-grass-by-madonna/

And then view the description for that theme inside of Firefox, you see this in the description:

My wallpaper to match is at: <a rel="nofollow" href="https://outgoing.mozilla.org/v1/60c071bd18d197fb27d8f9e9a4048beb36637663f3e331e8e6e51723913adb72/https%3A//nature.desktopnexus.com/wallpaper/2106268/">https://nature.desktopnexus.com/wallpaper/2106268/</a>

It should be a clickable link.

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 3

[David Durst [:ddurst]]

If we're pushing themes, let's do them justice.

Comment 4

[David Durst [:ddurst]]

Sorry, this intent is a little different than originally filed.

When pulling this into about:addons, we should remove links -- which I *think* is what amyt wanted -- rather than allowing the link to be rendered as authored.

Comment 5

[Amy Tsay [:amyt]]

Yes, given the choice between seeing the HTML for the link and seeing the link URL in plain text, we should choose the latter.

Comment 6

[Mark Striemer [:mstriemer]]

Took a quick look at the code and it looks like AMO returns outgoing links for extensions as well, but it seems to get filtered in _parseAddons [1]. Seems like that should be happening for themes too, though.


[1] https://searchfox.org/mozilla-central/rev/007b66c1f5f7a1b9a900a2038652a16a020f010c/toolkit/mozapps/extensions/internal/AddonRepository.jsm#620-621

Comment 7

[Andrew Swan [:aswan]]

(In reply to Mark Striemer [:mstriemer] from comment #6)
> Took a quick look at the code and it looks like AMO returns outgoing links
> for extensions as well, but it seems to get filtered in _parseAddons [1].
> Seems like that should be happening for themes too, though.

That should happen properly for xpi packaged themes, this report is about a LWT though.

Comment 8

[Mark Striemer [:mstriemer]]

Static themes would follow the code path I linked to in comment 6 which correctly displays the links. Since that conversion is going to happen before a fix in Firefox would get released there isn't much point in doing this anymore.