Closed
Bug 1263622
Opened 8 years ago
Closed 8 years ago
Fix nsNSSComponent.cpp compilation on mingw.
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
1.81 KB,
patch
|
keeler
:
review+
ted
:
review+
|
Details | Diff | Splinter Review |
There are two problems introduced by bug 1239166: - Includes should be use lower case (it doesn't matter on Windows, but does when cross compiling on case-sensitive OS like Linux). - We currently link xul.dll to crypt32 only for webrtc-enabled build. Since the commit, we use it also in nsNSSComponent.cpp, so we need to link it in all builds.
Attachment #8739981 -
Flags: review?(dkeeler)
Comment on attachment 8739981 [details] [diff] [review] fix Review of attachment 8739981 [details] [diff] [review]: ----------------------------------------------------------------- r=me for the nsNSSComponent changes. I think you'll need a build peer to sign off on the toolkit/library/moz.build changes.
Attachment #8739981 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8739981 [details] [diff] [review] fix Thanks.
Attachment #8739981 -
Flags: review?(ted)
Updated•8 years ago
|
Attachment #8739981 -
Flags: review?(ted) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/482df01e83b5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•