1263647 - Avoid unnecessary Tab:AudioPlayingChange messages

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

Managing Tab:AudioPlayingChange from one location is nice, but now we're sending out Tab:AudioPlayingChange messages when zombifying tabs even if the tab in question wasn't playing any audio.

Comment 1

[Jan Henning [:JanH]]

Attachment: MozReview Request: Bug 1263647 - When receiving a TabPreZombify event, send out a Tab:AudioPlayingChange message only if the tab is actually playing some audio. r=margaret

Review commit: https://reviewboard.mozilla.org/r/45485/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45485/

Comment 2

[:Margaret Leibovic]

Comment on attachment 8740012 [details]
MozReview Request: Bug 1263647 - When receiving a TabPreZombify event, send out a Tab:AudioPlayingChange message only if the tab is actually playing some audio. r=margaret

https://reviewboard.mozilla.org/r/45485/#review42409

::: mobile/android/chrome/content/browser.js:4104
(Diff revision 1)
>            return;
>          }
>  
> +        if (aEvent.type === "TabPreZombify" && !this.playingAudio) {
> +          return;
> +        }

Instead, what you could do, is create a `"TabPreZombify"` case up above the `"DOMAudio..."` cases, then fall through only if audio is actually playing.

Comment 3

[Jan Henning [:JanH]]

Comment on attachment 8740012 [details]
MozReview Request: Bug 1263647 - When receiving a TabPreZombify event, send out a Tab:AudioPlayingChange message only if the tab is actually playing some audio. r=margaret

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45485/diff/1-2/

Comment 4

[Jan Henning [:JanH]]

https://reviewboard.mozilla.org/r/45485/#review42409

> Instead, what you could do, is create a `"TabPreZombify"` case up above the `"DOMAudio..."` cases, then fall through only if audio is actually playing.

Thanks for the suggestion, I'm clearly too much under the influence of C#, where fall through is a no go. But as long as we don't do anything too fancy in PreTabZombify, it seems okay.

Comment 5

[:Margaret Leibovic]

Comment on attachment 8740012 [details]
MozReview Request: Bug 1263647 - When receiving a TabPreZombify event, send out a Tab:AudioPlayingChange message only if the tab is actually playing some audio. r=margaret

https://reviewboard.mozilla.org/r/45485/#review42993

Comment 6

[Jan Henning [:JanH]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbe3d76f1a63

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8cbd3940c47f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8cbd3940c47f