Closed
Bug 1263647
Opened 8 years ago
Closed 8 years ago
Avoid unnecessary Tab:AudioPlayingChange messages
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(1 file)
Managing Tab:AudioPlayingChange from one location is nice, but now we're sending out Tab:AudioPlayingChange messages when zombifying tabs even if the tab in question wasn't playing any audio.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45485/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45485/
Attachment #8740012 -
Flags: review?(margaret.leibovic)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jh+bugzilla
Comment 2•8 years ago
|
||
Comment on attachment 8740012 [details] MozReview Request: Bug 1263647 - When receiving a TabPreZombify event, send out a Tab:AudioPlayingChange message only if the tab is actually playing some audio. r=margaret https://reviewboard.mozilla.org/r/45485/#review42409 ::: mobile/android/chrome/content/browser.js:4104 (Diff revision 1) > return; > } > > + if (aEvent.type === "TabPreZombify" && !this.playingAudio) { > + return; > + } Instead, what you could do, is create a `"TabPreZombify"` case up above the `"DOMAudio..."` cases, then fall through only if audio is actually playing.
Attachment #8740012 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8740012 [details] MozReview Request: Bug 1263647 - When receiving a TabPreZombify event, send out a Tab:AudioPlayingChange message only if the tab is actually playing some audio. r=margaret Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45485/diff/1-2/
Attachment #8740012 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 4•8 years ago
|
||
https://reviewboard.mozilla.org/r/45485/#review42409 > Instead, what you could do, is create a `"TabPreZombify"` case up above the `"DOMAudio..."` cases, then fall through only if audio is actually playing. Thanks for the suggestion, I'm clearly too much under the influence of C#, where fall through is a no go. But as long as we don't do anything too fancy in PreTabZombify, it seems okay.
Comment 5•8 years ago
|
||
Comment on attachment 8740012 [details] MozReview Request: Bug 1263647 - When receiving a TabPreZombify event, send out a Tab:AudioPlayingChange message only if the tab is actually playing some audio. r=margaret https://reviewboard.mozilla.org/r/45485/#review42993
Attachment #8740012 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbe3d76f1a63
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8cbd3940c47f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•