1263683 - GCLI close-button icon is missing

Status: RESOLVED DUPLICATE of bug 1260751

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug (blank space in bottom-right corner)

STR:
 1. Open Developer Toolbar (Shift F2)

EXPECTED RESULTS: Close button at far right.
ACTUAL RESULTS: Blank empty space at far right.

If I click the blank space, the toolbar closes -- so the button is there. It's just missing an icon.

Comment 1

[Daniel Holbert [:dholbert]]

I'm using 64-bit Nightly 48.0a1 (2016-04-08) on Ubuntu Linux 16.04.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of correct rendering (in current release version, 45)

Comment 3

[Daniel Holbert [:dholbert]]

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=603181ac9e84f9a4a8dd6471e880860088f1d813&tochange=2a8ca5caae8e3a300701b0a85e5051ead55e0648

Looks like a regression from
> 2ee670054a59 Philip Chee — Bug 1257348 Fix for GCLI close button disappears when hovered over r=bgrins

Presumably that patch fixed whatever the hover issue was on some platforms, but it seems to have broken the icon on my Linux machine. (per this bug)

This is particularly concerning given that the patch was uplifted to Aurora -- so now we'll be shipping this regression directly to beta in a few weeks.  (I confirmed that I can reproduce this bug in the latest Aurora release, too.)

Philip or Brian, could you take a look at this and see if we can get this missing button fixed before we ship it as a beta regression?

Comment 4

[Daniel Holbert [:dholbert]]

[Tracking Requested - why for this release]: Very recent regression in nightly & now aurora (via an uplift of the regressing patch)

Comment 5

[Daniel Holbert [:dholbert]]

(This might be Linux-specific. I can't reproduce on Windows, at least -- only on Linux.)

Comment 6

[Brian Grinstead [:bgrins]]

I think this is a dupe of Bug 1260751, I'll copy the flags over to that bug

Comment 7

[Daniel Holbert [:dholbert]]

Yeah, looks like it. Thanks! I'll clear out the flags here so they don't end up with stale values if the situation changes on some version or another.