Closed Bug 1263725 Opened 4 years ago Closed 4 years ago

All Win64 e10s tests are going to permafail when Gecko 48 merges to Aurora

Categories

(Core :: Graphics, defect, critical)

x86_64
Windows
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox46 --- unaffected
firefox47 + fixed
firefox48 + fixed

People

(Reporter: RyanVM, Assigned: dvander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Mass win64 e10s test failures when Gecko 48 merges to Aurora.

I'm assuming this is sandboxing-related since it's win64 e10s only and there's sandbox-related stuff on those stacks. Does any of our sandboxing code depend on NIGHTLY_BUILD?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b3d47649e85&filter-searchStr=windows%20x64%20e10s&selectedJob=19232603

Sample log:
https://treeherder.mozilla.org/logviewer.html#?job_id=19232603&repo=try
Flags: needinfo?(bobowen.code)
NIGHTLY_BUILD is used to set MOZ_CONTENT_SANDBOX and prefs.

What specifically is the "sandbox-related stuff"?
Flags: needinfo?(bobowen.code) → needinfo?(ryanvm)
Observations from Bob on IRC:
bobowen: RyanVM: https://dxr.mozilla.org/mozilla-central/source/gfx/src/DriverCrashGuard.cpp#61
bobowen: RyanVM: https://hg.mozilla.org/mozilla-central/rev/b5a0c2bf1bca
bobowen: RyanVM: added D3D11Video, but it's not in https://dxr.mozilla.org/mozilla-central/source/dom/ipc/ContentParent.cpp#5650

Try bisection supports Bob's observations.
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=efe7d026ac64&tochange=6202ade0e6d6

Also, https://treeherder.mozilla.org/logviewer.html#?job_id=19232844&repo=try looks like the same issue with a more clear-cut link to DriverCrashGuard.
Blocks: 1253666
Component: Security: Process Sandboxing → Graphics
Flags: needinfo?(ryanvm) → needinfo?(dvander)
Attached patch fixSplinter Review
Good catch, thanks Bob.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Flags: needinfo?(dvander)
Attachment #8741230 - Flags: review?(matt.woodrow)
Attachment #8741230 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/30aa9ea0ad0c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.