Closed
Bug 1263766
Opened 8 years ago
Closed 8 years ago
Add in the necessary wiring to register a WebExtension API on android
Categories
(WebExtensions :: Untriaged, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
Iteration:
48.3 - Apr 25
People
(Reporter: mattw, Assigned: mattw)
References
Details
(Whiteboard: triaged)
Attachments
(1 file)
|
58 bytes,
text/x-review-board-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45647/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45647/
Attachment #8740229 -
Flags: review?(gbrown)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8740229 -
Flags: feedback?(kmaglione+bmo)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8740229 [details] MozReview Request: Bug 1263766 - Add in the wiring on android to support new WebExtension APIs. r?gbrown Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45647/diff/1-2/
Attachment #8740229 -
Attachment description: MozReview Request: Bug 1263766 - Add in the wiring on android to support new WebExtension APIs. f?kmag r?gbrown → MozReview Request: Bug 1263766 - Add in the wiring on android to support new WebExtension APIs. r?gbrown
Attachment #8740229 -
Flags: feedback?(kmaglione+bmo)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8740229 [details] MozReview Request: Bug 1263766 - Add in the wiring on android to support new WebExtension APIs. r?gbrown Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45647/diff/2-3/
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8740229 -
Flags: review?(gbrown) → review?(kmaglione+bmo)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8740229 -
Flags: feedback?(gbrown)
|
|
Assignee | |
Updated•8 years ago
|
Summary: Add in the necessary wiring to register an API → Add in the necessary wiring to register a WebExtension API on android
|
||
Comment 4•8 years ago
|
||
For the most part, this looks fine. In general, though, I'd prefer that we not land skeleton code before it's actually used. Landing the schema test now is probably a good idea, but I think the other parts should be landed along with a bug that actually requires them.
|
||
Comment 5•8 years ago
|
||
https://reviewboard.mozilla.org/r/45647/#review42439 ::: mobile/android/components/extensions/test/mochitest/test_ext_schema.html:1 (Diff revision 3) > +<!DOCTYPE HTML> This file looks just like toolkit/components/extensions/test/mochitest/test_ext_schema.html, which we already run on Android. eg. http://archive.mozilla.org/pub/mobile/tinderbox-builds/mozilla-inbound-android-api-15/1460488555/mozilla-inbound_ubuntu64_vm_armv7_large_test-mochitest-20-bm122-tests1-linux64-build6.txt.gz 13:06:01 INFO - 454 INFO TEST-START | toolkit/components/extensions/test/mochitest/test_ext_schema.html 13:06:01 INFO - 455 INFO TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_schema.html | took 4429ms Why the duplication?
|
||
Updated•8 years ago
|
Whiteboard: triaged
|
|
Assignee | |
Comment 6•8 years ago
|
||
gbrown, thanks for pointing this out. I added that test as a placeholder to confirm that the new directory structure was working properly, without knowing that it was already running on android - I'll remove it and add in a test for the PageAction api instead.
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8740229 [details] MozReview Request: Bug 1263766 - Add in the wiring on android to support new WebExtension APIs. r?gbrown Clearing flags on this, since I think we're agreed it doesn't need to land as a separate commit.
Attachment #8740229 -
Flags: review?(kmaglione+bmo)
Attachment #8740229 -
Flags: feedback?(gbrown)
|
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•