1263935 - Many "JavaScript warning: .../map-uri-to-addon-id.js, line 53: DebuggeeWouldRun: debuggee `.../addonManager.j" when opening the browser toolbox

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

It slows down the toolbox opening as these warnings are displayed in the browser toolbox's console. Also it highlights cases where we could potentially step into DebuggerServer dependencies. AddonManager modules (js xpcom and jsms) are not flagged as "invisible to debugger". Only modules loaded via devtools loader are.
(see bug 1263629 for similar issue with Promises)

I see multiple options here. We could:
* reduce as much as possible the call to this AddonManager dependency. Like not calling it for any known to be builtin URL (chrome://browser/, resource://gre, ...) But we will still leak a few calls...
* tweak AddonPathService to also expose mapURIToAddonId and used this native module rather than AddonManager js module.

The second option involve a c++ platform patch, but sounds great. It should also be faster...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Expose native version of mapURIToAddonId via amIAddonPathService - v1

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Forward AddonManager.mapURIToAddonId to AddonPathService.mapURIToAddonId - v1

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Use AddonPathService.mapURIToAddonId instead of AddonManager.mapURIToAddonID - v1

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ae4ccb17eeb

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab4b39b538ff

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Expose native version of mapURIToAddonId via amIAddonPathService - v1

Mossop, It would help devtools if we could use this native version of mapURIToAddonId.
So I'm suggesting here to expose it via the idl.
Then I have a set of patch to use that instead of the duplicated js version from xpiprovider.jsm.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Forward AddonManager.mapURIToAddonId to AddonPathService.mapURIToAddonId - v1

If you agree with previous patch, here is an optional cleanup to be done in AddonManager.
Also. Since this method seems to be only used by devtools code...
May be we could just drop this mapURIToAddonId and use the c++ service from devtools
(which I'm planning to do in the last patch).

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Use AddonPathService.mapURIToAddonId instead of AddonManager.mapURIToAddonID - v1

Waiting for mossop feedback before proceeding with devtools patch.

Comment 9

[Alexandre Poirot [:ochameau]]

Comment on attachment 8741048 [details] [diff] [review]
Use AddonPathService.mapURIToAddonId instead of AddonManager.mapURIToAddonID - v1

I also made a small optimisation by moving the "if (b2g)" on top level instead of within mapURIToAddonId so that we do the check only once.
And I changed the function arguments. It no longer uses an "id" argument and instead just returns the id.

Comment 10

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8741048 [details] [diff] [review]
Use AddonPathService.mapURIToAddonId instead of AddonManager.mapURIToAddonID - v1

Review of attachment 8741048 [details] [diff] [review]:
-----------------------------------------------------------------

I have no comments for a change :-P Go ahead and land this :-)

Comment 11

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/f171ce6678d567464ba0c40193a41561c746d76b
Bug 1263935 - Expose native version of mapURIToAddonId via amIAddonPathService. r=mossop

https://hg.mozilla.org/integration/fx-team/rev/27290170d6e06a85def4656e61582b63ab117a22
Bug 1263935 - Forward AddonManager.mapURIToAddonId to AddonPathService.mapURIToAddonId. r=mossop

https://hg.mozilla.org/integration/fx-team/rev/6a441b2b2997cdbd47b5d80283f6f60d5a9e7489
Bug 1263935 - Use AddonPathService.mapURIToAddonId instead of AddonManager.mapURIToAddonID. r=ejpbruel

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f171ce6678d5
https://hg.mozilla.org/mozilla-central/rev/27290170d6e0
https://hg.mozilla.org/mozilla-central/rev/6a441b2b2997