Closed Bug 1264037 Opened 4 years ago Closed 4 years ago

Add testing for CRX Extraction

Categories

(Core Graveyard :: File Handling, defect)

defect
Not set

Tracking

(firefox47 fixed, firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: bytesized, Assigned: bytesized)

References

Details

Attachments

(1 file)

CRX extractor (See Bug 1260836) needs testing.
Attachment #8740645 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8740645 [details]
MozReview Request: Bug 1264037 - Add testing for CRX reading

https://reviewboard.mozilla.org/r/45845/#review42507

r+, assuming try comes back green and the minor issues below are addressed. Thanks!

::: modules/libjar/test/unit/test_crx.js:9
(Diff revision 1)
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +function wrapInputStream(input)
> +{
> +  var nsIScriptableInputStream = Components.interfaces.nsIScriptableInputStream;

new code should use |let| instead of |var|, here and everywhere else in this file.

::: modules/libjar/test/unit/xpcshell.ini:20
(Diff revision 1)
>    data/test_corrupt.zip
>    data/test_corrupt2.zip
>    data/test_corrupt3.zip
>    data/test_umlaute.zip
>    data/uncompressed.zip
> +  data/test_crx_dummy.crx

This needs to move to the proper alphabetical order

::: modules/libjar/test/unit/xpcshell.ini:45
(Diff revision 1)
>  [test_dirjar_bug525755.js]
>  [test_jarinput_stream_zipreader_reference.js]
>  [test_not_found.js]
>  [test_uncompressed.js]
>  [test_umlaute.js]
> -
> +[test_crx.js]

alphabetical order
Attachment #8740645 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8740645 [details]
MozReview Request: Bug 1264037 - Add testing for CRX reading

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45845/diff/1-2/
Attachment #8740645 - Attachment description: MozReview Request: Bug 1264037 - Added test for CRX reading → MozReview Request: Bug 1264037 - Add testing for CRX reading
Attachment #8740645 - Flags: review+ → review?(spohl.mozilla.bugs)
Comment on attachment 8740645 [details]
MozReview Request: Bug 1264037 - Add testing for CRX reading

https://reviewboard.mozilla.org/r/45845/#review43023
Attachment #8740645 - Flags: review?(spohl.mozilla.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/3b3d8b016792
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Kirk/spohl: Should we include this in the widevine uplift?
Flags: needinfo?(spohl.mozilla.bugs)
Flags: needinfo?(ksteuber)
spohl says yes, we should uplift on IRC.
Flags: needinfo?(spohl.mozilla.bugs)
Flags: needinfo?(ksteuber)
Comment on attachment 8740645 [details]
MozReview Request: Bug 1264037 - Add testing for CRX reading

Requesting uplift for Firefox 47.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME support
[User impact if declined]: This adds a test for some of the earlier Widevine CDM install code.
[Describe test coverage new/current, TreeHerder]: This *is* a test. ;)
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Attachment #8740645 - Flags: approval-mozilla-aurora?
Comment on attachment 8740645 [details]
MozReview Request: Bug 1264037 - Add testing for CRX reading

Widevine related uplifts were pre-approved, automated test, yay!!!
Attachment #8740645 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.