Closed Bug 1264050 Opened 4 years ago Closed 4 years ago

The distribution/default directory should be checked even if there are no mcc or mnc directories

Categories

(Firefox for Android :: Android partner distribution, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

We should look in the distribution/default directory for distribution files in all cases (not just if mcc and mnc is present).

That way we can present one common layout for the distribution directory.
This adds the default directory to the list of distribution directories.

I also changed the error message for missing files to include the path. Makes debugging easier.
Attachment #8740608 - Flags: review?(s.kaspari)
(In reply to Mike Kaply [:mkaply] from comment #1)
> Created attachment 8740608 [details] [diff] [review]
> Always check the default directory
> 
> This adds the default directory to the list of distribution directories.
> 
> I also changed the error message for missing files to include the path.
> Makes debugging easier.

It makes debugging easier, but it might push more data than we want into the log. For privacy and security reasons, we avoid logging URLs and file paths, particularly file paths that include the profile folder name. Not sure what the file path is here, but "when in doubt, leave it out".

Yes, I just made that up.
That's funny. As I checked it in, I thought, "Should we be putting the username/profile in the log?"

You're right. I'll do a new patch.
Comment on attachment 8740608 [details] [diff] [review]
Always check the default directory

Review of attachment 8740608 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

If you create a distribution bundle[1] and we can't read the SIM card data then we should look into /default.

[1] https://wiki.mozilla.org/Mobile/Distribution_Files#Distribution_bundles
Attachment #8740608 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/6ef7f0a7ea41dcfd74ae70abe36fd03610e6bfec
Bug 1264050 - Use distribution/defaults directory even if is no SIM card data; r=sebastian
https://hg.mozilla.org/mozilla-central/rev/6ef7f0a7ea41
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.